Bugfix/EVS-NWPS_1606

[SamiraArdani-NOAA]

Note to developers: You must use this PR template!

Description of Changes

Please include a summary of the changes and the related GitHub issue(s). Please also include relevant motivation and context.

This PR addresses the Bugzilla 1606 - counting of models in python scripts for EVS-NWPS #638.

Developer Questions and Checklist

• Is this a high priority PR? If so, why and is there a date it needs to be merged by?
  No.
• Do you have any planned upcoming annual leave/PTO?
  No.
• Are there any changes needed in the times when the jobs are supposed to run/kick-off?
  No.

• The code changes follow NCO's EE2 Standards.
• Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
• References the feature branch for HOMEevs are removed from the code.
• J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
• Jobs over 15 minutes in runtime have restart capability.
• If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
• Jobs contain the appropriate file checking and don't run METplus for any missing data.
• Code is using METplus wrappers structure and not calling MET executables directly.
• Log is free of any ERRORs or WARNINGs.

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.

1- Clone my fork and checkout branch bugfix/EVS-NWPS_1606.
2- ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix fix
3- Point $COMIN to emc.vpppg in "plots" driver script.
4- Run the "plots" driver script located at: EVS/dev/drivers/scripts/plots/nwps/*.

[malloryprow]

1. jevs_nwps_wave_grid2obs_plots

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr650/EVS/dev/drivers/scripts/plots/nwps/jevs_nwps_wave_grid2obs_plots.o176992644
DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_nwps_wave_grid2obs_plots.176992644.cbqs01
COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr650/evs/v2.0

[SamiraArdani-NOAA]

@malloryprow, There was no error (ex. Traceback, etc.) in the log file. The output in $COMOUT looks identical to those in emc.vpppg.

[malloryprow]

One thing I did notice is ncpus 40.6 exceeded limit 36 (burst). I tried a test myself to increase the ncpus but still got a similar message. I can ask the WCOSS2 helpdesk about this since usually this issue is resolved by increase the ncpus.

Otherwise everything else looks good to me too!

[malloryprow]

Changes are good and testing successful.

Thanks for this PR! Be sure to cross off anything on the Fixes and Additions document this may cover.

[malloryprow]

I did some more testing before reaching out to NCO and I found that in scripts/plots/nwps/exevs_nwps_wave_grid2obs_plots.sh changing mpiexec -np 36 --cpu-bind verbose,core cfp plot_all_${MODELNAME}_${RUN}_g2o_${wfo}_plots.sh to mpiexec -np 36 --cpu-bind verbose,depth cfp plot_all_${MODELNAME}_${RUN}_g2o_${wfo}_plots.sh got rid of the message.

[AndrewBenjamin-NOAA]

I have reviewed the proposed changes and approve this PR

[malloryprow]

Can you do a sync fork when you get a chance @SamiraArdani-NOAA?

[SamiraArdani-NOAA]

@malloryprow, looks like this branch is already up to date.

[SamiraArdani-NOAA]

@malloryprow, got it! I am doing it now.

[malloryprow]

We just merged #649. You may need to sync your develop branch and then this branch.