feature/dev_evs_v1.0.17

[malloryprow]

Note to developers: You must use this PR template!

Description of Changes

This brings in the changes from the EVS v1.0.17 implementation into develop.

Developer Questions and Checklist

• Is this a high priority PR? If so, why and is there a date it needs to be merged by?

Yes, so the wafs stats job won't fail

• Do you have any planned upcoming annual leave/PTO?

No

• Are there any changes needed in the times when the jobs are supposed to run/kick-off?

No

• The code changes follow NCO's EE2 Standards.
• Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
• References the feature branch for HOMEevs are removed from the code.
• J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
• Jobs over 15 minutes in runtime have restart capability.
• If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
• Jobs contain the appropriate file checking and don't run METplus for any missing data.
• Code is using METplus wrappers structure and not calling MET executables directly.
• Log is free of any ERRORs or WARNINGs.

Testing Instructions

Set-up

1. Clone my fork and checkout branch feature/dev_evs_v1.0.17
2. ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix fix

🔲 wafs stats

3.cd dev/drivers/scripts/stats/wafs
4. Run jevs_wafs_atmos_stats.sh

[AliciaBentley-NOAA]

@malloryprow The changes made in https://github.com/NOAA-EMC/EVS/pull/577/files do not appear as changed code in this update. Should they? Or where they already there in develop?

[AliciaBentley-NOAA]

@malloryprow The changes made in https://github.com/NOAA-EMC/EVS/pull/579/files also do not appear as changed code in this update. Should they? Or were they already there in develop?

[AliciaBentley-NOAA]

@malloryprow The changes made in https://github.com/NOAA-EMC/EVS/pull/581/files also do not appear as changed code in this update. Should they? Or were they already there in develop?

[malloryprow]

All the plot unit conversion fixes are in develop since the images coming from the emc.vpppg parallel are correct.

#572 #526 #521

[AliciaBentley-NOAA]

@malloryprow Even weirder is that only some of the WAFS changes made it into this feature branch. The only one that appears to be missing are the changes made to jobs/JEVS_WAFS_ATMOS_STATS in https://github.com/NOAA-EMC/EVS/pull/576/files.

I feel like having none of the WAFS updates or all of the WAFS updates in a PR makes sense, but not missing one of the updates! Should we make the changes to jobs/JEVS_WAFS_ATMOS_STATS?

[malloryprow]

What changes are missing from JEVS_WAFS_ATMOS_STATS? I see the two line changes in this PR.

[AliciaBentley-NOAA]

@malloryprow JEVS_WAFS_ATMOS_STATS in the original WAFS PR seems to have become JEVS_WAFS_STATS in develop. I see the changes now, too!

[AliciaBentley-NOAA]

I have reviewed all of the changes made in this PR very thoroughly and can confirm that the changes made to the EVS v1.0.17 release are included in this PR. I approve this PR to be merged after necessary testing is complete.

CC @PerryShafran-NOAA @malloryprow

[PerryShafran-NOAA]

This PR is still in a draft form. Should I begin testing anyway?

[malloryprow]

Please wait until I can confirm that WAFS v7.0 went in. I emailed NCO about it but haven't heard. Once I know it is I'll move it out of draft.

[PerryShafran-NOAA]

OK, I'll wait to test until you give me the go ahead.

[malloryprow]

Good to test!

[PerryShafran-NOAA]

Test underway!

[AliciaBentley-NOAA]

@PerryShafran-NOAA @malloryprow I got the following missing file message from Perry's test.

WARNING: A subset of blend forecasts ( F18) is missing for GCIP valid date 2025012800. METplus continues.
Job ID: jevs_wafs_stats.178331765.cbqs01

[PerryShafran-NOAA]

@AliciaBentley-NOAA @malloryprow The missing file is:

WARNING: missing forecast /lfs/h1/ops/prod/com/wafs/v7.0/wafs.20250127/06/grib2/0p25/blending/WAFS_0p25_blended_2025012706f018.grib2
0 + echo 'WARNING: missing forecast /lfs/h1/ops/prod/com/wafs/v7.0/wafs.20250127/06/grib2/0p25/blending/WAFS_0p25_blended_2025012706f018.grib2'

Interestingly, the wafs.20250127 directory is the only one that has missing data in there. Due to the lack of any forecasts for 20250127, there are several WARNINGs throughout the output file. There are no ERRORs or anything else out of whack, and there are final stat files in the COMOUTfinal directory. Thus I think this is OK.

[PerryShafran-NOAA]

@malloryprow The job is finished:

.o file: /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr658test/EVS/dev/drivers/scripts/stats/wafs/jevs_wafs_stats.o178331765
small stats files: /lfs/h2/emc/vpppg/noscrub/perry.shafran/evs/v2.0/stats/wafs/atmos.20250128/wafs/grid2grid
final stats files: /lfs/h2/emc/vpppg/noscrub/perry.shafran/evs/v2.0/stats/wafs/wafs.20250128
working directory: /lfs/h2/emc/stmp/perry.shafran/evs_test/prod/tmp/jevs_wafs_stats.178331765.cbqs01

[malloryprow]

May need to keep an eye on if the missing file emails persist going forward.

The evs.stats.wafs.atmos.grid2grid_uvt1p25.v20250128.stat matches the parallel but evs.stats.wafs.atmos.grid2grid_icesev.v20250128.stat is different however this is expected. @YaliMao-NOAA told me this when she reviewed the files from the NCO para testing.

[PerryShafran-NOAA]

So wanted to be sure that you validated the results of this test, or would you care for another test for a different date?

[YaliMao-NOAA]

May need to keep an eye on if the missing file emails persist going forward.

The evs.stats.wafs.atmos.grid2grid_uvt1p25.v20250128.stat matches the parallel but evs.stats.wafs.atmos.grid2grid_icesev.v20250128.stat is different however this is expected. @YaliMao-NOAA told me this when she reviewed the files from the NCO para testing.

Yes, icesev stat file is different because the validation data GCIP is different which ingests METAR observation data, while METAR observation data keeps on accumulation dynamically over time.

I will evaluate WAFS EVS tomorrow which runs once per day, while WAFS just got implemented 12z today.

[malloryprow]

I believe we can merge this.

[PerryShafran-NOAA]

Changes work as expected. Approved for merge.

[YaliMao-NOAA]

@malloryprow @PerryShafran-NOAA
From 01/30/2025, parallel WAFS EVS was switched to WAFS operational data, the differences between parallel and operational WAFS EVS icesev stat files were gone.