Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ops_eo_14172 #667

Conversation

malloryprow
Copy link
Contributor

@malloryprow malloryprow commented Feb 13, 2025

Note to developers: You must use this PR template!

Description of Changes

The brings EVS ops to follow Executive Order 14172.

Developer Questions and Checklist

  • Is this a high priority PR? If so, why and is there a date it needs to be merged by?

Yes

  • Do you have any planned upcoming annual leave/PTO?

No

  • Are there any changes needed in the times when the jobs are supposed to run/kick-off?

No

  • The code changes follow NCO's EE2 Standards.
  • Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • References the feature branch for HOMEevs are removed from the code.
  • J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the appropriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

Set-up

  1. Clone my fork and checkout branch feature/ops_eo_4172
  2. ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix fix
  3. cd sorc; ./build
  4. Uncomment evs_ver in versions/run.ver

For everything below, be sure to set HOMEevs to the location of the clone and COMIN to /lfs/h1/ops/prod/com/$NET/$evs_ver_2

✔️ global_det stats

  1. cd dev/drivers/scripts/stats/global_det
  2. Run jevs_global_det_gfs_wave_grid2obs_stats.sh

✔️ global_det plots

  1. cd dev/drivers/scripts/plots/global_det
  2. Run jevs_global_det_wave_grid2obs_plots_last31days.sh

No need to test nwps because that is a new component in v2.0.

@malloryprow malloryprow added the update model or library updates label Feb 13, 2025
@malloryprow malloryprow added this to the EVS v1.0.19 milestone Feb 13, 2025
@PerryShafran-NOAA
Copy link
Contributor

Jobs are underway.

@PerryShafran-NOAA
Copy link
Contributor

The global_det stats information:

.o file: /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr667test/EVS/dev/drivers/scripts/stats/global_det/jevs_global_det_wave_gfs_grid2obs_stats_00.o180531451
small stats files: /lfs/h2/emc/vpppg/noscrub/perry.shafran/evs/v1.0/stats/global_det/wave.20250212/wave.20250212/gfs/grid2obs
large stats files: /lfs/h2/emc/vpppg/noscrub/perry.shafran/evs/v1.0/stats/global_det/wave.20250212/gfs.20250212
working directory: /lfs/h2/emc/stmp/perry.shafran/evs_test/prod/tmp/jevs_global_det_wave_gfs_grid2obs_stats_00.180531451.cbqs01

@PerryShafran-NOAA
Copy link
Contributor

The global_det plots information:

.o files: /lfs/h2/emc/vpppg/noscrub/perry.shafran/pr667test/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_31days_00.o180531548
plot tarball: /lfs/h2/emc/ptmp/perry.shafran/evs/v1.0/plots/global_det/wave.20250212
working directory: /lfs/h2/emc/stmp/perry.shafran/evs_test/prod/tmp/jevs_global_det_wave_grid2obs_plots_31days_00.180531548.cbqs01

Copy link
Contributor

@AliciaBentley-NOAA AliciaBentley-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this changes and found them to be in compliance with our directives. I approve this PR to be merged after testing is completed.

CC @malloryprow @PerryShafran-NOAA

@malloryprow
Copy link
Contributor Author

👍 stats is good

@PerryShafran-NOAA
Copy link
Contributor

Plots is complete if you wish to take a look-see.

@malloryprow
Copy link
Contributor Author

Ah, same thing happened here like in #666. Can we do the same thing but have COMIN be /lfs/h2/emc/vpppg/noscrub/perry.shafran/evs/v1.0?

@PerryShafran-NOAA
Copy link
Contributor

Yup, the job is working now. Check again in a bit when it's complete; directories the same.

@malloryprow
Copy link
Contributor Author

@PerryShafran-NOAA You reran it with COMIN=/lfs/h1/emc.vpppg/noscrub/perry.shafran/evs/v1.0 instead of /lfs/h2/emc.vpppg/noscrub/perry.shafran/evs/v1.0

@PerryShafran-NOAA
Copy link
Contributor

Whoops! Let me fix this and restart.

@malloryprow
Copy link
Contributor Author

Good to go here. I'll submit the CDF tomorrow when I get in.

@PerryShafran-NOAA
Copy link
Contributor

OK then, I'll merge this in.

Copy link
Contributor

@PerryShafran-NOAA PerryShafran-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works as expected. Approved for merge.

@PerryShafran-NOAA PerryShafran-NOAA merged commit 1d067fa into NOAA-EMC:release/evs.v1.0.19 Feb 13, 2025
@malloryprow malloryprow deleted the feature/ops_eo_14172 branch February 18, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update model or library updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants