Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global_ens: SST ice fix #668

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

GwenChen-NOAA
Copy link
Contributor

Description of Changes

This PR fixes the SST issue with ice temp definition discrepancies between the forecasts and observations by filtering out data < 271.15 (K) in Ensemble _Stat. Test run results are available at
https://www.emc.ncep.noaa.gov/users/verification/global/gefs/test/atmos/grid2grid/sst/

Developer Questions and Checklist

  • Is this a high priority PR? If so, why and is there a date it needs to be merged by? Yes.
  • Do you have any planned upcoming annual leave/PTO? No.
  • Are there any changes needed in the times when the jobs are supposed to run/kick-off? No.
  • The code changes follow NCO's EE2 Standards.
  • Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • References the feature branch for HOMEevs are removed from the code.
  • J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the appropriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

(1) Set up jobs
a. Symlink the EVS_fix directory locally as "fix".
b. In the driver scripts, edit the following environment variables:

HOMEevs - set to your test EVS directory
COMIN - set to /lfs/h2/emc/vpppg/noscrub/emc.vpppg/${NET}/$evs_ver_2d
COMOUT - set to your test output directory

(2) Run jobs
Run the following job in EVS/dev/drivers/scripts/stats/global_ens:

qsub jevs_global_ens_gefs_atmos_sst_stats.sh

@malloryprow malloryprow self-assigned this Feb 19, 2025
@malloryprow malloryprow added this to the EVS v2.0.0 milestone Feb 19, 2025
@malloryprow malloryprow added the enhancement New feature or request label Feb 19, 2025
@malloryprow
Copy link
Contributor

I see that there are no changes needed for the plots. global_det and subseasonal needed changes in the plots step to be able to pick up the new threshold. I know that global_ens uses different plotting scripts than global_det and subseasonal, but just I wanted to check.

@malloryprow
Copy link
Contributor

1. jevs_global_ens_gefs_atmos_sst_stats

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr668/EVS/dev/drivers/scripts/stats/global_ens/jevs_global_ens_gefs_atmos_sst_stats.o181041603
DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_gefs_atmos_sst_stats.181041603.cbqs01
COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr668/evs/v2.0/stats/global_ens

@GwenChen-NOAA
Copy link
Contributor Author

I see that there are no changes needed for the plots. global_det and subseasonal needed changes in the plots step to be able to pick up the new threshold. I know that global_ens uses different plotting scripts than global_det and subseasonal, but just I wanted to check.

The global_det and subseasonal components use Grid_Stat and cnt_thresh and cnt_logic config options to filter out data < 271.15 K, and the threshold values appear in the FCST_THRESH and OBS_THRESH columns of stat files and plot titles. So, they need to adjust the plotting code to remove the threshold notation in the plot titles. The global_ens component uses Ensemble_Stat and censor_thresh and censor_val config options, and the threshold values do not appear in the FCST_THRESH and OBS_THRESH columns. So, no impacts to the plot titles and plotting code. I set ENSEMBLE_STAT_DESC = GE271.15 in the config file, so GE271.15 appears in the DESC column of stat files as a note.

@GwenChen-NOAA
Copy link
Contributor Author

1. jevs_global_ens_gefs_atmos_sst_stats

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr668/EVS/dev/drivers/scripts/stats/global_ens/jevs_global_ens_gefs_atmos_sst_stats.o181041603 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_gefs_atmos_sst_stats.181041603.cbqs01 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr668/evs/v2.0/stats/global_ens

The output looks good to me.

@malloryprow
Copy link
Contributor

Noted, thanks for the explanation!

Copy link
Contributor

@malloryprow malloryprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are good and testing successful.

Thanks for these changes @GwenChen-NOAA!

Copy link
Contributor

@AliciaBentley-NOAA AliciaBentley-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and think that it looks good! I approve it to be merged! Thanks!

CC @malloryprow @GwenChen-NOAA

@malloryprow malloryprow merged commit 4ed0116 into NOAA-EMC:develop Feb 19, 2025
@malloryprow
Copy link
Contributor

Just updated para to bring in these changes. jevs_global_ens_gefs_atmos_sst_stats already ran for the day but so the changes will be in the stats starting tomorrow for the parallel.

@GwenChen-NOAA
Copy link
Contributor Author

Is it possible to bring these changes to prod via a EVS bugfix? The global_ens SST verification shown in the prod webpage is way off.

@AliciaBentley-NOAA
Copy link
Contributor

@GwenChen-NOAA Unfortunately, it is not possible to submit another EVS bugfix code delivery to NCO at this time. We've already sent them two and they weren't supposed to accept any from us! I will break the SST link on the webpage to prevent the prod images from being displayed. The SST fixes for global_ens, global_det, and subseasonal will need to make their way to prod in EVS v2.0. Thanks for asking!

CC @malloryprow

@GwenChen-NOAA
Copy link
Contributor Author

Ok, I will take down the global_ens SST prod webpage and start archiving sst stat files from emc.vpppg parallel to cut down the days needed for rerun. cc @ShannonShields-NOAA and @QiShi-NOAA for their awareness.

@AliciaBentley-NOAA
Copy link
Contributor

@GwenChen-NOAA Thanks! I updated the global_ens webpage this morning to prevent the incorrect SST images from displaying on the /prod webpage. I think this quick fix would be much less work than you removing the SST option from the left-hand side menus on all of the global_ens pages, just for you to add it back again later, etc. I hope this solution works for you!

@GwenChen-NOAA
Copy link
Contributor Author

Thanks, @AliciaBentley-NOAA! I saw the image section is blank now.

@GwenChen-NOAA GwenChen-NOAA deleted the sst_ice_fix branch February 27, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants