Wind direction stats and plots for global wave #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malloryprow
reviewed
Feb 26, 2025
malloryprow
reviewed
Feb 26, 2025
malloryprow
reviewed
Feb 26, 2025
1. jevs_global_det_gfs_wave_grid2obs_stats.shLog File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/stats/global_det/jevs_global_det_gfs_wave_grid2obs_stats_00.o181716267 |
|
Hi Mallory,
I've added my names to the list of developers.
…On Wed, Feb 26, 2025 at 10:52 AM Mallory Row ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ush/global_det/global_det_wave_plots_grid2obs_timeseries_WindDir.sh
<#671 (comment)>:
> @@ -0,0 +1,121 @@
+#!/bin/bash
+###############################################################################
+# Name of Script: global_det_wave_timeseries.sh
+# Developers: Deanna Spindler / ***@***.***
+# Mallory Row / ***@***.***
You can change my information to your information or add or name to the
list of developers
—
Reply to this email directly, view it on GitHub
<#671 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN27LMUXPRTTGGZ6ZVLT2RXPKHAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBVGAYDIOBXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The output stats looks good.No ERROR, error, or Error in the log file.
Below is two messages related to the job when I ran check_evs_logs.sh over
the log file:
nid003166: 2025-02-26T16:09:09.912303+00:00 nid003166
systemd-tmpfiles[537152]: /usr/lib/tmpfiles.d/inn.conf:1: Failed to resolve
user 'news': No such process
nid003166: 2025-02-26T16:09:09.915887+00:00 nid003166
systemd-tmpfiles[537152]: /usr/lib/tmpfiles.d/svnserve.conf:1: Failed to
resolve user 'svn': No such process
…On Wed, Feb 26, 2025 at 11:07 AM Mallory Row ***@***.***> wrote:
1. jevs_global_det_gfs_wave_grid2obs_stats.sh
*Log File:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/stats/global_det/
*DATA:*
/lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_det_gfs_wave_grid2obs_stats_00.181716267.cbqs01
*COMOUT:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/evs/v2.0/stats/global_det
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN23G6DGUPDUZWC7XQXT2RXREFAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGUYTQMJYGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
<#671 (comment)>
1. jevs_global_det_gfs_wave_grid2obs_stats.sh
*Log File:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/stats/global_det/
*DATA:*
/lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_det_gfs_wave_grid2obs_stats_00.181716267.cbqs01
*COMOUT:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/evs/v2.0/stats/global_det
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN23G6DGUPDUZWC7XQXT2RXREFAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGUYTQMJYGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I saw that too. I don't think that is anything we can control and is related to things on WCOSS2. |
ush/global_det/settings.py
Outdated
| @@ -719,7 +719,7 @@ def __init__(self): | |||
| 'DPT': 'Dewpoint Temperature', | |||
| 'UGRD': 'Zonal Wind Speed', | |||
| 'VGRD': 'Meridional Wind Speed', | |||
| 'UGRD_VGRD': 'Vector Wind Speed', | |||
| 'UGRD_VGRD': 'Wind Direction', | |||
There was a problem hiding this comment.
If 'UGRD_VGRD' has been changed to 'Wind Direction', what is being used for 'Vector Wind Speed' (which is something we would still like to verify out of EVS)? Are the U and V Wind Speed components being used for that? I'd hate to remove something we still want. Thanks!
There was a problem hiding this comment.
May have answered my own question:
'UGRD_VGRD10m': 'Surface Vector Wind Speed',
Is this the replacement?
AliciaBentley-NOAA
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
I have reviewed this PR and think that it looks very good! I asked one question about continuing to verify vector wind speed once that parameter was changed to 'wind direction', but I scrolled down and believe wind speed was added back later in the same file under a new name. I approve this PR to be merged after successful testing (e.g., proof that wind direction AND wind speed verification looks good). Thanks!
|
So the plot scripts automatically use this definition for the second line
of plot tile and y axis. I can change it back to Vector wind speed and add
if statements in the plot script if that is preferred.
…On Wed, Feb 26, 2025 at 11:46 AM Alicia Bentley ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ush/global_det/settings.py
<#671 (comment)>:
> @@ -719,7 +719,7 @@ def __init__(self):
'DPT': 'Dewpoint Temperature',
'UGRD': 'Zonal Wind Speed',
'VGRD': 'Meridional Wind Speed',
- 'UGRD_VGRD': 'Vector Wind Speed',
+ 'UGRD_VGRD': 'Wind Direction',
If 'UGRD_VGRD' has been changed to 'Wind Direction', what is being used
for 'Vector Wind Speed' (which is something we would still like to verify
out of EVS)? Are the U and V Wind Speed components being used for that? I'd
hate to remove something we still want. Thanks!
CC @QiShi-NOAA <https://github.com/QiShi-NOAA> @malloryprow
<https://github.com/malloryprow>
—
Reply to this email directly, view it on GitHub
<#671 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN27HIQTXXX57637ECCD2RXVWDAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBVGE3DCOJYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
For Wind Speed, global_det wave is using the "WIND" variable. 'UGRD_VGRD' is technically Vector Winds but global_det wave isn't using that. So the changes work, but if statements may be useful to prevent any problems in the future. |
|
I agree, I'll work on the if statement for plots. It should be easy.
Best,
Qi
…On Wed, Feb 26, 2025 at 11:57 AM Mallory Row ***@***.***> wrote:
For Wind Speed, global_det wave is using the "WIND" variable. 'UGRD_VGRD'
is technically Vector Winds but global_det wave isn't using that.
So the changes work, but if statements may be useful to prevent any
problems in the future.
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN23ULEYDYXNCLU7OGET2RXXBHAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGY2TCMZYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
<#671 (comment)>
For Wind Speed, global_det wave is using the "WIND" variable. 'UGRD_VGRD'
is technically Vector Winds but global_det wave isn't using that.
So the changes work, but if statements may be useful to prevent any
problems in the future.
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN23ULEYDYXNCLU7OGET2RXXBHAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGY2TCMZYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
added 2 commits
February 26, 2025 18:57
to wind direction) for wind direction modify the file name in global_det_wave_plots comments section stats plot in time series.py and lead_average.py
|
I've added the if statement in time_series.py and lead_average.py. And I've
restored the UGRD_VGRD variable description to vector wind speed.
On Wed, Feb 26, 2025 at 12:00 PM Qi Shi - NOAA Affiliate ***@***.***>
wrote:
… I agree, I'll work on the if statement for plots. It should be easy.
Best,
Qi
On Wed, Feb 26, 2025 at 11:57 AM Mallory Row ***@***.***>
wrote:
> For Wind Speed, global_det wave is using the "WIND" variable. 'UGRD_VGRD'
> is technically Vector Winds but global_det wave isn't using that.
>
> So the changes work, but if statements may be useful to prevent any
> problems in the future.
>
> —
> Reply to this email directly, view it on GitHub
> <#671 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BMPTN23ULEYDYXNCLU7OGET2RXXBHAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGY2TCMZYG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
> [image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
> <#671 (comment)>
>
> For Wind Speed, global_det wave is using the "WIND" variable. 'UGRD_VGRD'
> is technically Vector Winds but global_det wave isn't using that.
>
> So the changes work, but if statements may be useful to prevent any
> problems in the future.
>
> —
> Reply to this email directly, view it on GitHub
> <#671 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BMPTN23ULEYDYXNCLU7OGET2RXXBHAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGY2TCMZYG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
COMOUT is /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/evs/v2.0/plots/global_det/wave.20250226. 1. jevs_global_det_wave_grid2obs_plots_last31daysLog File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last31days_00.o181817051 2. jevs_global_det_wave_grid2obs_plots_last90daysLog File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last90days_00.o181817063 |
|
@QiShi-NOAA The jobs are done running. Yesterday in the global meeting you mentioned you updated the website to display the images. Can you put them the website and send a link to it? |
|
HI mallory,
Will do.
Best,
Qi
…On Thu, Feb 27, 2025 at 10:37 AM Mallory Row ***@***.***> wrote:
@QiShi-NOAA <https://github.com/QiShi-NOAA> The jobs are done running.
Yesterday in the global meeting you mentioned you updated the website to
display the images. Can you put them the website and send a link to it?
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN22YSSSERYH5OEBFW7L2R4WMZAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYGMZTEOJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
<#671 (comment)>
@QiShi-NOAA <https://github.com/QiShi-NOAA> The jobs are done running.
Yesterday in the global meeting you mentioned you updated the website to
display the images. Can you put them the website and send a link to it?
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN22YSSSERYH5OEBFW7L2R4WMZAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYGMZTEOJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The images are displaced on the website:
https://www.emc.ncep.noaa.gov/users/verification/global/gfs/test/wave/grid2obs/wdir/
…On Thu, Feb 27, 2025 at 10:37 AM Mallory Row ***@***.***> wrote:
@QiShi-NOAA <https://github.com/QiShi-NOAA> The jobs are done running.
Yesterday in the global meeting you mentioned you updated the website to
display the images. Can you put them the website and send a link to it?
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN22YSSSERYH5OEBFW7L2R4WMZAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYGMZTEOJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
<#671 (comment)>
@QiShi-NOAA <https://github.com/QiShi-NOAA> The jobs are done running.
Yesterday in the global meeting you mentioned you updated the website to
display the images. Can you put them the website and send a link to it?
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN22YSSSERYH5OEBFW7L2R4WMZAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYGMZTEOJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I think we may want to take "Wind Direction" out of the titles and webpage drop down. This would be more consistent with the other plots and webpages for global_det wave. "Mean Absolute Wind Direction Difference" -> "Mean Absolute Error" |
|
Ok, I'll work on that.
…On Thu, Feb 27, 2025 at 1:11 PM Mallory Row ***@***.***> wrote:
I think we may want to take "Wind Direction" out of the titles and webpage
drop down. This would be more consistent with the other plots and webpages
for global_det wave.
"Mean Absolute Wind Direction Difference" -> "Mean Absolute Error"
"Mean Wind Direction Difference" -> "Mean Error (Bias)"
"Root Mean Square Wind Direction Difference" -> "Root Mean Square Error"
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN226GBNJANEG62HJXQ32R5IN7AVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYG4ZTEMZRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
<#671 (comment)>
I think we may want to take "Wind Direction" out of the titles and webpage
drop down. This would be more consistent with the other plots and webpages
for global_det wave.
"Mean Absolute Wind Direction Difference" -> "Mean Absolute Error"
"Mean Wind Direction Difference" -> "Mean Error (Bias)"
"Root Mean Square Wind Direction Difference" -> "Root Mean Square Error"
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN226GBNJANEG62HJXQ32R5IN7AVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYG4ZTEMZRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I've updated the code with "WInd Direction" being removed.from plot title
in the feature branch.
…On Thu, Feb 27, 2025 at 1:11 PM Mallory Row ***@***.***> wrote:
I think we may want to take "Wind Direction" out of the titles and webpage
drop down. This would be more consistent with the other plots and webpages
for global_det wave.
"Mean Absolute Wind Direction Difference" -> "Mean Absolute Error"
"Mean Wind Direction Difference" -> "Mean Error (Bias)"
"Root Mean Square Wind Direction Difference" -> "Root Mean Square Error"
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN226GBNJANEG62HJXQ32R5IN7AVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYG4ZTEMZRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
<#671 (comment)>
I think we may want to take "Wind Direction" out of the titles and webpage
drop down. This would be more consistent with the other plots and webpages
for global_det wave.
"Mean Absolute Wind Direction Difference" -> "Mean Absolute Error"
"Mean Wind Direction Difference" -> "Mean Error (Bias)"
"Root Mean Square Wind Direction Difference" -> "Root Mean Square Error"
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN226GBNJANEG62HJXQ32R5IN7AVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYG4ZTEMZRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
COMOUT is /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/evs/v2.0/plots/global_det/wave.20250226 (cleared out before rerunning). 1. jevs_global_det_wave_grid2obs_plots_last31daysLog File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last31days_00.o181831674 2. jevs_global_det_wave_grid2obs_plots_last90daysLog File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last90days_00.o181831675 |
|
The output looks good and no errors are found in log files.
You can view the images on the website:
https://www.emc.ncep.noaa.gov/users/verification/global/gfs/test/wave/grid2obs/wdir/
…On Thu, Feb 27, 2025 at 3:24 PM Mallory Row ***@***.***> wrote:
COMOUT is
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/evs/v2.0/plots/global_det/wave.20250226
(cleared out before rerunning).
1. jevs_global_det_wave_grid2obs_plots_last31days
*Log File:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last31days_00.o181831674
*DATA:*
/lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_det_wave_grid2obs_plots_last31days_00.181831674.cbqs01
2. jevs_global_det_wave_grid2obs_plots_last90days
*Log File:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last90days_00.o181831675
*DATA:*
/lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_det_wave_grid2obs_plots_last90days_00.181831675.cbqs01
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN26UVOFIRIHVAWJ2S5L2R5X6FAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGAZTIOBWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: malloryprow]*malloryprow* left a comment (NOAA-EMC/EVS#671)
<#671 (comment)>
COMOUT is
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/evs/v2.0/plots/global_det/wave.20250226
(cleared out before rerunning).
1. jevs_global_det_wave_grid2obs_plots_last31days
*Log File:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last31days_00.o181831674
*DATA:*
/lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_det_wave_grid2obs_plots_last31days_00.181831674.cbqs01
2. jevs_global_det_wave_grid2obs_plots_last90days
*Log File:*
/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr671/EVS/dev/drivers/scripts/plots/global_det/jevs_global_det_wave_grid2obs_plots_last90days_00.o181831675
*DATA:*
/lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_det_wave_grid2obs_plots_last90days_00.181831675.cbqs01
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN26UVOFIRIHVAWJ2S5L2R5X6FAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGAZTIOBWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@QiShi-NOAA Can you please sync your fork? Shannon's subseasonal PR was merged earlier today. Also, does anything else need to be rerun on this PR before it is merged? |
|
HI Alicia,
I've synced my wind direction fork. No rerun needed on this PR before it is
merged.
Best,
Qi
…On Mon, Mar 3, 2025 at 8:57 PM Alicia Bentley ***@***.***> wrote:
@QiShi-NOAA <https://github.com/QiShi-NOAA> Can you please sync your
fork? Shannon's subseasonal PR was merged earlier today. Also, does
anything else need to be rerun on this PR before it is merged?
CC @PerryShafran-NOAA <https://github.com/PerryShafran-NOAA>
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN24TIEGWQ7E24ZOZLO32SUB6RAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVHE4DGNRUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: AliciaBentley-NOAA]*AliciaBentley-NOAA* left a comment
(NOAA-EMC/EVS#671)
<#671 (comment)>
@QiShi-NOAA <https://github.com/QiShi-NOAA> Can you please sync your
fork? Shannon's subseasonal PR was merged earlier today. Also, does
anything else need to be rerun on this PR before it is merged?
CC @PerryShafran-NOAA <https://github.com/PerryShafran-NOAA>
—
Reply to this email directly, view it on GitHub
<#671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPTN24TIEGWQ7E24ZOZLO32SUB6RAVCNFSM6AAAAABX5R4PBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVHE4DGNRUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@QiShi-NOAA I'll be doing the final code review and then I'll merge this code. |
PerryShafran-NOAA
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to developers: You must use this PR template!
Description of Changes
This PR adds wind direction verification metrics (dir_me, dir_mae and dir_rmse) for global wave.
Developer Questions and Checklist
${USER}where necessary throughout the code.HOMEevsare removed from the code.dev/drivers/scriptsordev/modulefileshave been made in the correspondingecf/scriptsandecf/defs/evs-nco.def?Testing Instructions