-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rtofs in situ #1138
Feature/rtofs in situ #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @givelberg . A few minor comments related to the ctest. We'll figure out where to keep these RTOFS binaries next week.
excluding *.cc in rtofs from the linter
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. I didn't see any other HEAD
or residuals from your last merge, but you might want to double check.
Also, you need to merge develop into your branch again.
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @givelberg !
This PR changed the hash for the following repos in This PR changed gsibec to `gsibec @ e6e1944. This commit is dated June 26, 2203. Before this PR was merged into g-w C96C48_ufs_hybatmDA CI using the current head of GDASApp (7f4c2fc) failed when running the gfs and gdas atmanlvar. Both job aborted with the error message
This reason for this failure is that the We need to revert |
Ouch, sorry about this @RussTreadon-NOAA . Not quite sure how I missed this but I did ... |
into feature/rename_atm * 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp: Feature/rtofs in situ (#1138) Updates to aerosol yaml templates (#1158) Use standard config files for jjob test and give output files better names (#1156) Temporary removal of soca_vrfy task (#1157) Fix keyword for float tolerances in jjob tests (#1154) Create template YAML for n21 aerosol obs and update obs QC in YAMLs (#1152) Changes name of rossrad file for letkf (#1151) Adds staging jinja/yaml file for letkf task (#1137)
Created 2 converters with corresponding tests, for temperature and salinity.
2 different files are created.
For temperature the file includes
tmp, tmp_err, lon, lat, depth
and metadata sal_typ and flg
Similarly, for salinity..