Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point the CI to the dev/gdasapp global workflow branch #1169

Closed
wants to merge 6 commits into from
Closed

Point the CI to the dev/gdasapp global workflow branch #1169

wants to merge 6 commits into from

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Jun 12, 2024 •
edited
Loading

I have not touched the "stable" script, this is just to change the CI to point to dev/gdsaapp.

I'll work next on fixing the gw_ci test, for some reason the hpc account is not updated properly. But in the meantime, the plan is to do bushiness as usual with a different branch.

RussTreadon-NOAA
RussTreadon-NOAA previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@guillaumevernieres
Copy link
Contributor Author

Approve

Thanks @RussTreadon-NOAA . I should have done that before submitting this PR: I'm going to update the README as well ...

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jun 12, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jun 12, 2024
danholdaway
danholdaway previously approved these changes Jun 12, 2024
View reviewed changes
@emcbot
Copy link

emcbot commented Jun 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jun 12 17:56:21 UTC 2024 on hfe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jun 12 18:49:43 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jun 12 19:16:33 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jun 12, 2024
@RussTreadon-NOAA
Copy link
Contributor

I manually ran gw_driver.sh as role.jedipara on Hera. It ran to completion for this PR, #1169, and finished with the following command line output in the Hera PuTTY session

+ /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/repo/ci/run_gw_ci.sh -d /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169/global-workflow -o /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169/output_e0c4c8e
Begin link_workflow.sh at Wed Jun 12 18:49:43 UTC 2024
End link_workflow.sh at 18:49:43 with error code 0 (time elapsed: 00:00:00)
+ ci_status=0
+ gh pr comment 1169 --body-file /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169/output_e0c4c8e
https://github.com/NOAA-EMC/GDASApp/pull/1169#issuecomment-2163735457
+ '[' 0 -eq 0 ']'
+ gh pr edit 1169 --remove-label hera-GW-RT-Running --add-label hera-GW-RT-Passed
https://github.com/NOAA-EMC/GDASApp/pull/1169
+ find /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169 -maxdepth 1 -mtime +3 -exec rm -rf '{}' ';'

Looks like CI from role.jedipara works. I have not yet enabled a cron to run CI in the background. The above test was executed from the command line.

@CoryMartin-NOAA
Copy link
Contributor

@RussTreadon-NOAA perhaps tomorrow morning we coordinate turning it on for jedipara and off for my account, and we see how it goes tomorrow and Friday?

@guillaumevernieres guillaumevernieres removed the orion-GW-RT Queue for automated testing with global-workflow on Orion label Jun 12, 2024
@guillaumevernieres
Copy link
Contributor Author

@CoryMartin-NOAA , @RussTreadon-NOAA , @danholdaway I added some logic to check for a companion pr in the global-workflow and clone that if it does exist. I only tested a small chunk of the added script, running the ci again now.

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jun 12, 2024
@emcbot emcbot added the hera-GW-RT-Running Automated testing with global-workflow running on Hera label Jun 12, 2024
@emcbot emcbot removed the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jun 12, 2024
@emcbot
Copy link

emcbot commented Jun 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jun 12 22:10:40 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jun 12 22:52:06 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jun 12 23:17:10 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48

@emcbot emcbot removed the hera-GW-RT-Running Automated testing with global-workflow running on Hera label Jun 12, 2024
@guillaumevernieres
Copy link
Contributor Author

Note for tomorrow: check that the g-w and gdasapp branches that were checked out is the correct ones.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jun 13, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jun 13, 2024
@emcbot
Copy link

emcbot commented Jun 13, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Jun 13 16:21:57 UTC 2024 on hfe01
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jun 13 16:22:33 UTC 2024
Tests: 
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jun 13, 2024
@emcbot
Copy link

emcbot commented Jun 13, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Jun 13 16:21:57 UTC 2024 on hfe01
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jun 13 16:22:33 UTC 2024
Tests: 
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/gdas.cd/build/log.ctest

Build: SUCCESS
Build: Completed at Thu Jun 13 17:07:48 UTC 2024

Tests: SUCCESS
Tests: Completed at Thu Jun 13 17:32:34 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48

@emcbot emcbot added the hera-GW-RT-Passed Automated testing with global-workflow successful on Hera label Jun 13, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jun 14, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jun 14, 2024
@emcbot
Copy link

emcbot commented Jun 14, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Jun 14 19:15:44 UTC 2024 on hfe08
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Jun 14 19:20:48 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/log.build

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jun 14, 2024
@CoryMartin-NOAA
Copy link
Contributor

@guillaumevernieres @RussTreadon-NOAA FYI I'm going to be on leave until Thursday so I won't be able to help debug the CI running in my user account. I'm going to revert it to develop again, just so existing capabilities are not broken. Debugging can happen on the role account if necessary.

@RussTreadon-NOAA
Copy link
Contributor

Hera test
Did the following as role.jedipara

  1. clone feature/devgdasapp
  2. cp ci/gw_driver.sh /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/repo/ci
  3. create forked g-w branch named feature/ci to match the same branch name, feature/ci, referenced by GDASApp PR #1173
  4. add label hera-GW-RT to GDASApp PR #1173
  5. execute /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/repo/ci/gw_driver.sh -t hera
  6. 48 our of 48 test_gdasapp pass
  7. PR #1173 label updated to hera-GW-RT-Passed

@emcbot
Copy link

emcbot commented Jun 14, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Jun 14 19:15:44 UTC 2024 on hfe08
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Jun 14 19:20:48 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/log.build

Build: SUCCESS
Build: Completed at Fri Jun 14 20:06:48 UTC 2024

Tests: Failed
Tests: Failed at Fri Jun 14 21:30:33 UTC 2024
Tests: 98% tests passed, 1 tests failed out of 48
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/gdas.cd/build/log.ctest

@RussTreadon-NOAA
Copy link
Contributor

Changes in feature/devgdasapp have been merged into RussTreadon-NOAA:feature/ci. See PR #1173

@guillaumevernieres
Copy link
Contributor Author

Changes included in #1173

@guillaumevernieres guillaumevernieres deleted the feature/devgdasapp branch July 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

@danholdaway danholdaway Awaiting requested review from danholdaway

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the dev/gdasapp global-worflow branch for the CI test
5 participants
@guillaumevernieres @emcbot @RussTreadon-NOAA @CoryMartin-NOAA @danholdaway