Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to the halo issue in the variance partitioning code #1171

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Fix to the halo issue in the variance partitioning code #1171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
024d26d
switched functionspace
guillaumevernieres Jun 13, 2024
e5efe8f
Merge branch 'develop' into bugfix/soca-diagb
guillaumevernieres Jun 13, 2024
2a810b0
tidy
guillaumevernieres Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions utils/soca/gdas_soca_diagb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,12 @@ namespace gdasapp {
}

// Update the layer thickness halo
xbFs["hocn"].haloExchange();
nodeColumns.haloExchange(xbFs["hocn"]);

// Loop through variables
for (auto & var : configD.socaVars.variables()) {
// Update the halo
xbFs[var].haloExchange();
nodeColumns.haloExchange(xbFs[var]);

// Skip the layer thickness variable
if (var == "hocn") {
Expand Down Expand Up @@ -361,7 +361,7 @@ namespace gdasapp {
// Horizontal averaging
for (int iter = 0; iter < configD.niterHoriz; ++iter) {
// Update the halo points
bkgErrFs[var].haloExchange();
nodeColumns.haloExchange(bkgErrFs[var]);
auto stdDevBkg = atlas::array::make_view<double, 2>(bkgErrFs[var]);

// Loops through nodes and levels
Expand Down
Loading