-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tier-2 tests #1185
Tier-2 tests #1185
Conversation
g-w C96C48_ufs_hybatmDA CI runs the following jobs
g-w CI runs jobs after the above DA jobs finish. This is useful since it ensures the generated analysis increment files are readable by downstream jobs. However, adding these downstream jobs to GDASApp CI is too much at this point. |
I probably won't be able to get you a list of aero+snow jobs until early next week, so don't wait for me if you want to proceed with this PR, otherwise I can get that to you Mon or Tues |
I updated the non-existent PR description @RussTreadon-NOAA , but the idea is to not run these as part of the regular GDASApp CI, but rather only prior to doing a PR in the global-workflow develop. |
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
These are the new tests added:
... and as I'm seeing that list, I'm thinking we probably need a new label or a way to trigger only a subset of these. |
…DASApp into feature/tier2-testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I see Tier-2
testing was a SUCCESS , we don't see a hera-GW-RT-tier2-Passed label.
A check of labels only shows hera-GW-RT-tier2. Do we need to add Running, Failed, Passed labels for hera-GW-RT-tier2?
Sorry for the confusion @RussTreadon-NOAA . The tier-2 test actually did not run, but even if they did, only the GW-RT label would be updated. The label is just there to trigger the tier-2 test, I could rename it to |
Thanks @guillaumevernieres for the explanation. I think renaming the tier-2 test trigger label would be helpful. Would the |
You could trigger them on other machines, but currently the marine DA ones would fail. We've been meaning to update the yamls in the g-w ... On our todo list. |
Got it. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve.
Not sure what I did but the tier-2 is not triggered anymore ... Great. |
@guillaumevernieres should we keep this PR alive or close it? |
Tier-2 tests would not be part of the regular GDASApp CI and would only be executed prior to submitting a PR of
dev/gdasapp
intodevelop
.Untested.
@CoryMartin-NOAA , @RussTreadon-NOAA , could you give me a sequential list of the
jjobs
that you want tested? That or commit directly to my branch. What needs to be updated is hereGDASApp/test/gw-ci/CMakeLists.txt
Line 61 in 6f27a49
and here
GDASApp/test/gw-ci/CMakeLists.txt
Line 68 in 6f27a49
and the marine DA example is here:
GDASApp/test/gw-ci/CMakeLists.txt
Line 47 in 6f27a49