Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JPSSRR sea-ice product to ioda converter #1259

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Add JPSSRR sea-ice product to ioda converter #1259

merged 6 commits into from
Aug 27, 2024

Conversation

apchoiCMD
Copy link
Collaborator

Description

  • Task for adding a new ioda converter for new sea-ice concentration
  • For sea-ice, AMSR2, MIRS and JPSSRR product will be used

Partially addressed #1182

@apchoiCMD apchoiCMD marked this pull request as ready for review August 22, 2024 16:31
guillaumevernieres
guillaumevernieres reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @apchoiCMD . Just one minor comment to check for values > 1. We'll trigger the ci after you make the change.

utils/obsproc/IcecJpssrr2Ioda.h Outdated Show resolved Hide resolved
AndrewEichmann-NOAA
AndrewEichmann-NOAA reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issues

utils/obsproc/IcecJpssrr2Ioda.h Show resolved Hide resolved
utils/obsproc/IcecJpssrr2Ioda.h Show resolved Hide resolved
@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Aug 27, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Aug 27, 2024
@emcbot
Copy link

emcbot commented Aug 27, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Aug 27 17:21:56 UTC 2024 on hfe05
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Aug 27 18:05:32 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Aug 27 18:53:12 UTC 2024
Tests: 83% tests passed, 8 tests failed out of 47
	1533 - test_gdasapp_util_prepdata (Failed)
	1910 - test_gdasapp_atm_jjob_ens_obs (Failed)
	1911 - test_gdasapp_atm_jjob_ens_sol (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1259/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Aug 27, 2024
@RussTreadon-NOAA
Copy link
Contributor

test_gdasapp_atm_jjob_ens_obs and test_gdasapp_atm_jjob_ens_sol failures are expected until g-w PR #2833 is merged into g-w develop.

@apchoiCMD
Copy link
Collaborator Author

apchoiCMD commented Aug 27, 2024 •
edited
Loading

cdl files with ncgen are problem on Hera. They are good on Orion, will update them ASAP.

(base) [Mindo.Choi@hfe03 testdata]$ ncgen -o output_1.nc4 icec_jrr_n20_1.cdl
ncgen: NetCDF: Not a valid data type or _FillValue type mismatch

@apchoiCMD apchoiCMD added hera-RT Queue for automated testing on Hera hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-RT Queue for automated testing on Hera labels Aug 27, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Aug 27, 2024
@emcbot
Copy link

emcbot commented Aug 27, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Aug 27 20:21:12 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Aug 27 21:08:30 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Aug 27 21:30:43 UTC 2024
Tests: 96% tests passed, 2 tests failed out of 47
	1910 - test_gdasapp_atm_jjob_ens_obs (Failed)
	1911 - test_gdasapp_atm_jjob_ens_sol (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1259/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot removed the hera-GW-RT-Running Automated testing with global-workflow running on Hera label Aug 27, 2024
guillaumevernieres
guillaumevernieres approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guillaumevernieres guillaumevernieres merged commit 419c21f into develop Aug 27, 2024
11 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/jpssrr_sea_ice branch August 27, 2024 23:57
DavidHuber-NOAA added a commit to DavidHuber-NOAA/GDASApp that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
10edded 
* origin/develop:
  Turn on OMA diagnostics after JEDI minimization (NOAA-EMC#1274)
  Adding AHI and SEVIRI satwnd thinning, enrolling AHI-H9, SEVIRI-M9, SEVIRI-M10 (NOAA-EMC#1263)
  add ctest to create yaml for lgetkf observer ctest (NOAA-EMC#1272)
  add soca fix yaml file for 1deg (NOAA-EMC#1270)
  Fix to marine post and archiving (NOAA-EMC#1266)
  Add JPSSRR sea-ice product to ioda converter (NOAA-EMC#1259)
  enable atmospheric lgetkf ctests to run in combined and split modes (NOAA-EMC#1262)
@apchoiCMD apchoiCMD mentioned this pull request Sep 26, 2024
Merged
guillaumevernieres added a commit that referenced this pull request Oct 1, 2024
@apchoiCMD @guillaumevernieres
Yamls for JPSSRR sea-ice obs in cycling test (#1300)
af67dc0 
#### This PR is to add the yaml keys
- Yaml keys for JPSSRR sea-ice for the cycling
- The file names of JPSSRR type sea-ice are the same in `NH` and `SH`,
please see in `yamls` and `obsprep_config.yaml`
- The preliminary results here/below

![GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600_NH](https://github.com/user-attachments/assets/d8276e1d-5fcb-4c04-92d7-67e902523035)
- Obs for the SH is not ready yet



Related to #1259

---------

Co-authored-by: Guillaume Vernieres <[email protected]>
jiaruidong2017 pushed a commit that referenced this pull request Oct 3, 2024
@apchoiCMD @guillaumevernieres @jiaruidong2017
Yamls for JPSSRR sea-ice obs in cycling test (#1300)
37331a2 
#### This PR is to add the yaml keys
- Yaml keys for JPSSRR sea-ice for the cycling
- The file names of JPSSRR type sea-ice are the same in `NH` and `SH`,
please see in `yamls` and `obsprep_config.yaml`
- The preliminary results here/below

![GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600_NH](https://github.com/user-attachments/assets/d8276e1d-5fcb-4c04-92d7-67e902523035)
- Obs for the SH is not ready yet



Related to #1259

---------

Co-authored-by: Guillaume Vernieres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA left review comments

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@JohnSteffen-NOAA JohnSteffen-NOAA JohnSteffen-NOAA left review comments

@givelberg givelberg Awaiting requested review from givelberg

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apchoiCMD @emcbot @RussTreadon-NOAA @guillaumevernieres @AndrewEichmann-NOAA @JohnSteffen-NOAA