Marine B-matrix refactor companion PR #1346
Conversation
DavidNew-NOAA
requested review from
guillaumevernieres,
AndrewEichmann-NOAA,
danholdaway and
CoryMartin-NOAA
DavidNew-NOAA
dismissed stale reviews from guillaumevernieres and danholdaway
via
1660f1a
This PR is a companion to Global Workflow PR [#2992](NOAA-EMC/global-workflow#2992) and GDASApp PR [#1346](NOAA-EMC/GDASApp#1346). It adds JCB templates for the input YAMLS of JEDI applications used in the marine B-matrix task in the Global Workflow. --------- Co-authored-by: Dan Holdaway <[email protected]> Co-authored-by: Guillaume Vernieres <[email protected]>
|
@guillaumevernieres @AndrewEichmann-NOAA @danholdaway @CoryMartin-NOAA Can I get a final review on this PR, so we can merge and hopefully move forward on GW PR #2992 next week? |
|
This PR will break marine testing until GW PR #2992 is merged, so I might as well wait until I meet with Rahul and Walter next week to hash out the issues with that PR before I merge this one. The companion jcb-gdas PR that just got merged shouldn't break anything though, so that's good. |
develop is broken anyways, the default state ... But yes, lets hold on! |
|
I'm going to go ahead and merge this PR since GW PR #2992 should be ready for review soon after discussing with the GW team yesterday. Let me know if anyone objects. |
Go for it. We'll have bugfixes coming in after yours (#1359), but what you have in this PR should still be OK with the low-res test cases. |
This PR is a companion to Global Workflow PR #2992 and JCB-GDAS PR #36.
It makes a few necessary changes to the marine JCB base YAML required to have JCB working in the B-matrix task in the Global Workflow.