Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for soca using icepack as a module #1444

Merged
merged 3 commits into from
Jan 18, 2025
Merged

Update for soca using icepack as a module #1444

merged 3 commits into from
Jan 18, 2025

Conversation

shlyaeva
Copy link
Collaborator

Description

Preparation for JCSDA-internal/soca#1116: icepack (limited) becomes module of soca (it's used in Soca2Cice), so it can be removed from the bundle and modules in GDASapp.

I am keeping this PR as draft until soca PR is merged.
Once this update is finished and all associated PRs are merged, I'll update icepack to a newer version.

Companion PRs

JCSDA-internal/soca#1116

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA RussTreadon-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jan 15, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 15, 2025
@emcbot
Copy link

emcbot commented Jan 15, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Wed Jan 15 13:37:40 UTC 2025 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jan 15 14:19:20 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jan 15 14:37:44 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 53

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 15, 2025
RussTreadon-NOAA
RussTreadon-NOAA previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run GW-RT on Hera. All tests pass.

Approve.

@guillaumevernieres
Copy link
Contributor

guillaumevernieres commented Jan 15, 2025 •
edited
Loading

Run GW-RT on Hera. All tests pass.

Approve.

uh-oh, why would the test pass? The soca PR isn't merged yet.
It might build, build but the soca2cice step should have failed?

@shlyaeva
Copy link
Collaborator Author

@guillaumevernieres because the PR is pointing to the correct soca hash (even though it's not in develop yet)

guillaumevernieres
guillaumevernieres previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RussTreadon-NOAA
Copy link
Contributor

When soca #1116 is merged into soca develop, the stable-nightly job running on Hera will pull the updated soca hash into feature/stable-nightly ... assuming all tests pass (they should pass as this draft PR demonstrates).

We can then open a GDASApp PR to merge feature/stable-nightly into develop. The updated develop can be pulled into feature/icepack_submodule and this PR marked Ready for review.

@shlyaeva
Copy link
Collaborator Author

soca PR was just merged; moving this out of draft.

@shlyaeva shlyaeva marked this pull request as ready for review January 17, 2025 14:23
@guillaumevernieres
Copy link
Contributor

soca PR was just merged; moving this out of draft.

I don't think the soca commit is correct @shlyaeva

@shlyaeva
Copy link
Collaborator Author

@guillaumevernieres thank you, I'll fix it

@shlyaeva
Copy link
Collaborator Author

The commit should be correct now; thank you @guillaumevernieres for catching this!

guillaumevernieres
guillaumevernieres approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shlyaeva !

@RussTreadon-NOAA RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jan 18, 2025
@emcbot emcbot added the hera-GW-RT-Running Automated testing with global-workflow running on Hera label Jan 18, 2025
@emcbot emcbot removed the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jan 18, 2025
@emcbot
Copy link

emcbot commented Jan 18, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Sat Jan 18 13:10:10 UTC 2025 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sat Jan 18 13:55:13 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Sat Jan 18 14:15:42 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 53

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 18, 2025
@RussTreadon-NOAA RussTreadon-NOAA self-requested a review January 18, 2025 14:19
RussTreadon-NOAA
RussTreadon-NOAA approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCDA ctests pass.

Approve.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 70ea55b into develop Jan 18, 2025
11 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/icepack_submodule branch January 18, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

Assignees

@shlyaeva shlyaeva

Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shlyaeva @emcbot @guillaumevernieres @RussTreadon-NOAA @CoryMartin-NOAA