Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_bufr2ioda.sh with run_bufr2ioda.py #601

Merged
merged 12 commits into from
Sep 6, 2023

Conversation

RussTreadon-NOAA
Copy link
Contributor

g-w PR #1826 states that ush/ioda/bufr2ioda/run_bufr2iobs.sh must be in python (see comment here).

Given this, GDASApp branch feature/bufr2iodapy was created to replace run_bufr2ioda.sh with run_bufr2ioda.py.

To fully integrate run_bufr2ioda.py into g-w the decision was made to replace variable DUMP in parm/ioda/bufr2ioda/bufr2ioda_satwind_amv_goes.json with CDUMP, the current cycle. With this change tests reported in g-w #1826 verify that run_bufr2ioda.py generates output identical to that from run_bufr2ioda.sh.

This PR is opened to replace run_bufr2ioda.sh with run_bufr2ioda.py and update parm/ioda/bufr2ioda/bufr2ioda_satwind_amv_goes.json as described above.

Fixes #599

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong with what is here, but this is mostly a direct translation of bash to python, if we are using python, we should take advantage of that fact.

ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
@RussTreadon-NOAA
Copy link
Contributor Author

Test GDASApp branch feature/bufr2iodapy along with g-w branch RussTreadon-NOAA:feature/iodaobs on Hera and Orion for 20210814 18 gdas. Job prepatmiodaobs ran to completion on both machines. IODA dump files were created for GOES-16 and GOES-17 ABI from the bufr satwnd dump file.

Does this PR require any additional revisions?

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Sep 6, 2023
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me for now, we can revisit later if we find a 'clever' way to do this in python

ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Show resolved Hide resolved
ush/ioda/bufr2ioda/run_bufr2ioda.py Outdated Show resolved Hide resolved
@CoryMartin-NOAA CoryMartin-NOAA merged commit 0073a5f into develop Sep 6, 2023
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/bufr2iodapy branch September 6, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor run_bufr2ioda.sh as run_bufr2ioda.py
3 participants