-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace run_bufr2ioda.sh with run_bufr2ioda.py #601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wrong with what is here, but this is mostly a direct translation of bash to python, if we are using python, we should take advantage of that fact.
Test GDASApp branch Does this PR require any additional revisions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me for now, we can revisit later if we find a 'clever' way to do this in python
g-w PR #1826 states that
ush/ioda/bufr2ioda/run_bufr2iobs.sh
must be in python (see comment here).Given this, GDASApp branch
feature/bufr2iodapy
was created to replacerun_bufr2ioda.sh
withrun_bufr2ioda.py
.To fully integrate
run_bufr2ioda.py
into g-w the decision was made to replace variableDUMP
inparm/ioda/bufr2ioda/bufr2ioda_satwind_amv_goes.json
withCDUMP
, the current cycle. With this change tests reported in g-w #1826 verify thatrun_bufr2ioda.py
generates output identical to that fromrun_bufr2ioda.sh
.This PR is opened to replace
run_bufr2ioda.sh
withrun_bufr2ioda.py
and updateparm/ioda/bufr2ioda/bufr2ioda_satwind_amv_goes.json
as described above.Fixes #599