Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfinished example of a RADS to ioda converter #606

Merged
merged 9 commits into from
Sep 8, 2023

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Sep 8, 2023

Description

This PR adds a prototype IODA converter that will be used as a template for the other netdcf observation files that will need to be converted.
I added a base class for the conversion in NetCDFToIodaConverter.h, it probably could do more but for now the only thing useful it does is saving the ioda file.

RADS to IODA implementation

  • The derived class from the above that actually does something useful is called Rads2Ioda and it implements the reading of the RADS netcdf files, which is a virtual function of NetCDFToIodaConverter
  • The application code is under obsproc/applications

Testing

  • I added a sub-sampled cdl RADS file that is converted back to netcdf in a ctest
  • The ctest reads the RADS netcdf file and creates a IODA file. It's not testing anything more than successful completion
  • The converter is not complete, it's missing most of the MetaData and a few other things ...

Issues addressed

utils/obsproc/NetCDFToIodaConverter.h Outdated Show resolved Hide resolved
utils/obsproc/Rads2Ioda.h Outdated Show resolved Hide resolved
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 8, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 8, 2023
@guillaumevernieres
Copy link
Contributor Author

I think the test will fail, there's a bug in the oops develop that was probably cloned by the ci ... The culprit pr was just reverted ~30mn ago. Zut!

Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok - what's a cdl file?

@CoryMartin-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA it's a text file in the same format as what ncdump dumps out that you can use to create a netCDF file.

@emcbot
Copy link

emcbot commented Sep 8, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Sep  8 16:05:50 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Sep  8 17:13:09 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Sep  8 17:34:31 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 51

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 8, 2023
@apchoiCMD apchoiCMD self-requested a review September 8, 2023 17:46
@emcbot
Copy link

emcbot commented Sep 8, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Sep  8 11:02:50 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Sep  8 12:26:52 CDT 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Sep  8 13:01:11 CDT 2023
Tests: 100% tests passed, 0 tests failed out of 51

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Sep 8, 2023
@guillaumevernieres guillaumevernieres merged commit 784fabd into develop Sep 8, 2023
17 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/cppiodaconv branch September 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create template and example based on RADS altimetry to ioda
6 participants