Fix issues on hera with test data #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoryMartin-NOAA
requested review from
guillaumevernieres,
ShastriPaturi,
RussTreadon-NOAA,
emilyhcliu,
ADCollard,
CatherineThomas-NOAA and
andytangborn
RussTreadon-NOAA
approved these changes
Oct 20, 2023
guillaumevernieres
approved these changes
Oct 20, 2023
|
FYI, the Hera build successfully completed. |
|
I could also build on Hera. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCSDA changed the logic by which test data is downloaded.
First, new top level CMake flags have to be added, else it will try to download tarballs rather than use the cloned repos.
Second, CRTM has no choice, if they are not already available, the code will try to download a tarball.
These tarballs are currently unavailable from Hera, as the host server is blocked. The logic should work fine on other machines though.
This PR fixes this on Hera but including the CMake flags for all platforms, and staging/linking the CRTM coefficients from a place I have them already installed on Hera.