-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalize layout for reading GSI static-B #689
generalize layout for reading GSI static-B #689
Conversation
Orion ctests
Test
Rerun jobs This PR does not alter files used by the |
@RussTreadon-NOAA this is an issue that will be fixed in an OOPS PR, we can revert the switch to linear time interpolation in GDASApp, or wait until OOPS's PR is merged. But this is a known issue right now regardless of platform. |
Thank you @CoryMartin-NOAA for explaining why the |
@RussTreadon-NOAA I think we give it a couple of days and if it is still not merged, then we can come up with an interim solution. |
Hera ctests
These results mirror those obtained on Orion. The |
The associated g-w PR #1945 has been merged into g-w |
@CoryMartin-NOAA , would you like to review this PR again or can we go ahead and merge? No new changes have been committed to |
Thank you, @CoryMartin-NOAA. |
This PR replaces the hardwired {3,2} layout for reading the GSI static-B with variables {
layout_gsib_x
,layout_gsib_y
}. Modifications are made to g-wconfig.resources
to set the new variables.Fixes #680
Depends on g-w issue #1936