-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conventional station pressure (conv_ps) for testing and end-to-end #698
Conversation
…o error inflation for duplicate observations and the JEDI window length definition, the window length in the script has to be relaxed so that all observations from the 6-hour obs data will be accounted for.
…or pressure check.
…ata window between GSI and JEDI.
…into feature/conv_ps
@emilyhcliu can you resolve the conflicts and merge in develop, then I think this is ready to go! (well once the JCSDA merges the UFO pr) |
@CoryMartin-NOAA Done: Updated the branch, resolved the conflict, and did git push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, will not merge until UFO PR is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except one general question: why surface_geometric_height is replaced by surface_altitude for geovar_sfc_geomz?
@PraveenKumar-NOAA Thanks for reviewing this PR.
You can use either one.
The surface_altitude is the default and then GMAO added a second default (surface_geometric_height)
312165f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@CoryMartin-NOAA I updated the test_yamls.sh to run CI test with and without QC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @emilyhcliu!
@CoryMartin-NOAA The UFO PR related to this PR has been approved and merged into UFO. We are good to merge if Mr. Goofy (@ADCollard ) agrees with the changes in test_yaml.sh. |
This PR is to update the station pressure with the following modifications:
Modify YAMLs under testing (UFO Evaluation)
Add YAMLs under config (End-to-End)
This will be tested during the code sprint.
Add handling for CI tests with and without QC
To closely replicate the error assignment from the GSI error table. The ObsFunctionModelStepwiseLinear needs to add the capability of rounding the output of this function to the nearest integer. A related https://github.com/JCSDA-internal/ufo/pull/3085 has been submitted in the UFO repository.
Notes for test data set:
Please see T2O Issue #96 for documentation and UFO evaluation test results.
The CI test for conv_ps should change to green after merging this PR.