Feature/nick e conventional prepbufr #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys.path.append update
coding norm updates
np arrays added for adpsfc/sfcshp. Need to be tested when orion comes back.
heightOfStation is MetaData, stationElevation is ObsValue, ObsTypes added
nicholasesposito
requested review from
CoryMartin-NOAA,
emilyhcliu,
ADCollard and
PraveenKumar-NOAA
CoryMartin-NOAA
approved these changes
Nov 13, 2023
ADCollard
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the conventional surface bufr data converter (using the python api) to the GDASApp. Data is from ADPSFC, SFCSHP and ADPUPA at the surface.
The two files added are:
~/ush/ioda/bufr2ioda/bufr2ioda_conventional_ps_prepbufr.py
~/parm/ioda/bufr2ioda/bufr2ioda_conventional_ps_prepbufr.json
This is validated in GDASApp issue #649
The PRs for acft_profiles_prepbufr and GPSRO bufr should be added before this (PR #712 and #708 ) so that run_bufr2ioda.py works
There are a huge number of numpy/masked array variable sets because they kept overwriting for unknown reasons throughout, and kept resulting in data further down the line getting messed up, especially fill_values. Fill_values for numpy and ma are different for reasons only the python developers know, but as of right now, the fill_Values are all good and show up as "_"