-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comparison capability to RadMon regional web sites. #160
Add comparison capability to RadMon regional web sites. #160
Conversation
Add comparison capability to regional web sites.
There is no test plot showing on this link https://www.emc.ncep.noaa.gov/gmb/gdas/radiance/esafford/regional/testz/. Should I expect to see the figures? |
I just linked in data from the NAM for testing purposes and those links aged out. I just updated the data and the summary plots are working. I'll update the links again on Monday. The time series data is still available, but I'll have to update that by Monday as well. |
@xyzemc I updated the data this morning. For the summary plots if you switch on NAM data (top left check box) you'll see that comparison data overlaid. Since I'm using NAM data and calling "testz" the curves will be the same but the comparison plot is done last, so you'll see the curves change colors indicating the inclusion of the NAM data. For the time series there is a little bit of mismatch because the data I pulled over this morning hasn't been updated while the current NAM data has been updated. That means there will be some cycles at the left end of the plots that the comparison data doesn't match and will be zeroed out. Hope that makes sense. Anyway, please have a look when you have a moment. Thanks. |
It looks good for me now. I will approve this PR. Thanks! |
|
||
if [[ $short = "Y" || $short = "y" ]]; then | ||
do_cmp=1 | ||
cmp_src="NAM" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change 'NAM' to 'RRFS' when RRFS becomes the operational system and replace NAM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely. The default comparison should always be the operational regional model, as the default global is GFS and will need to be changed to its successor(s). I should move the declaration of cmp_src to the top of the file so it's easy to find and replace. I'll go ahead and do that. You might have to re-approve the PR again after I make those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated install_glb.sh
and install_rgn.sh
scripts to place the default values at the top of each file and de-referenced them with variables. That will make updating them in the future more straightforward. Please take a look if you have a chance. I've re-tested the website builds and the scripts are working as intended.
Make requested changes to default comparison assignments.
This PR adds a comparison capability to RadMon regional web sites in a similar fashion as is done for global sites.
When running
Install_html.sh
the user is asked if they would like to enable comparison plots, and if so, what source should be used for the comparison (the default is the operational NAM). If enabled comparison plots are enabled in the summary and time series plots.A working example built during testing can be seen at https://www.emc.ncep.noaa.gov/gmb/gdas/radiance/esafford/regional/testz/ .
Additionally some unrelated modifications to the
plot_time.html.glb
were made to fix these problems:Note that the result of the Install_html.sh script is that the customized html and other web files are placed in the user's
$TANKDIR/imgn/regional/$SUFFIX
directory. A manual transfer of these files to the web server is required. An automatic transfer mechanism will be added in a separate issue.Closes #157