Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed type of g2c_inq_prod() parameters #499

Merged
merged 2 commits into from
Jul 9, 2024
Merged

changed type of g2c_inq_prod() parameters #499

merged 2 commits into from
Jul 9, 2024

Conversation

edwardhartnett
Copy link
Contributor

Fixes #391

@edwardhartnett edwardhartnett marked this pull request as ready for review July 9, 2024 11:45
Hang-Lei-NOAA
Hang-Lei-NOAA approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Hang-Lei-NOAA Hang-Lei-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is safe to use long parameters

@edwardhartnett edwardhartnett merged commit 53444de into develop Jul 9, 2024
33 checks passed
@edwardhartnett edwardhartnett deleted the ejh_types branch July 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hang-Lei-NOAA Hang-Lei-NOAA Hang-Lei-NOAA approved these changes

@AlexanderRichert-NOAA AlexanderRichert-NOAA Awaiting requested review from AlexanderRichert-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change g2c_inq_prod to use long long int for template values
2 participants
@edwardhartnett @Hang-Lei-NOAA