Fix bug with g2c_aecpackf()/g2c_aecpackd() and add test #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlysonStahl-NOAA
requested review from
edwardhartnett,
AlexanderRichert-NOAA and
Hang-Lei-NOAA
tests/tst_aec.c
Outdated
| for (i = 0; i < DATA_LEN; i++) | ||
| { | ||
| /* printf("%g %g\n", fld[i], fld_in[i]); */ | ||
| if (fld[i] != fld_in[i]) |
There was a problem hiding this comment.
Minor quibble, but should this be getting compared within some small tolerance since it's floating-point data?
AlexanderRichert-NOAA
approved these changes
Sep 21, 2024
edwardhartnett
approved these changes
Sep 22, 2024
|
Is this ready to merge? |
|
It is now. I just added those fixes to the value comparison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #511