Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to plot QC Flags on map #83

Merged
merged 12 commits into from
Oct 21, 2021
Merged

Conversation

kevindougherty-noaa
Copy link
Collaborator

@kevindougherty-noaa kevindougherty-noaa commented Oct 13, 2021

Creates a 2D map that plots the location of the qc flags. Addresses number 2.), 4th bullet in #84. An example is shown here:

image

Need to create a yaml and driver script to run.

@kevindougherty-noaa kevindougherty-noaa marked this pull request as ready for review October 13, 2021 19:32
@kevindougherty-noaa kevindougherty-noaa changed the base branch from develop to feature/LAMDA October 13, 2021 19:34
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments which will probably require more work than what is possible before your 2 days of PTO and weekend :-)

import plot_features as features


def no_data_map(plotmap, domain, metadata):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved to a more generic part of emcpy as there may be other uses for this outside of LAMDA

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to move it up one directory because it could be useful in other parts of PyGSI as I plan to add other examples that already exist in pyGSI/plot_diags.py

plotdir : (str; default='./') path to where figures should be saved
"""

diag = Radiance(inputfile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this generic for all obs types? What if we want to plot QC values of conventional data (say satwinds)? Will it work to just pass the diag object to this function, or do we need to handle all three classes here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good question. To my understanding, there are no qc flags for conventional data, only assimilated, rejected and monitored data. So this script is pretty specific to just Radiance data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are QC flags for conventional data for sure, I think there are two Setup_QC_Mark and Prep_QC_Mark but am not totally sure of what should be used (probably Setup)

@CoryMartin-NOAA CoryMartin-NOAA merged commit b203b06 into feature/LAMDA Oct 21, 2021
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/qcflag_map branch October 21, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants