Develop minimization plots #85
Conversation
| """ | ||
| # Get cycle info | ||
| cycle = df.index.get_level_values(0)[-1] | ||
| cyclestr = datetime.strftime(cycle, '%Y%m%d%H') |
There was a problem hiding this comment.
Only question is how to handle the tm06 information for this plot?
LAMDA/minimization_plots.py
Outdated
| myplot.add_ylabel('log (J)') | ||
| myplot.add_legend(loc='upper right', | ||
| fontsize='large') | ||
| myplot.add_title('FV3LAM Cost', loc='left') |
There was a problem hiding this comment.
Since there are multiple experiments (FV3LAMDA, LAMDAX, etc.) can we make the title include an optional experiment name passed to the function?
LAMDA/minimization_plots.py
Outdated
| plt.close('all') | ||
|
|
||
|
|
||
| def _plot_gnorm(df, outdir): |
There was a problem hiding this comment.
same two comments for this function as the first one.
LAMDA/minimization_plots.py
Outdated
| _plot_gnorm(df, outdir) | ||
| _plot_cost_function(df, outdir) | ||
| _plot_gnorm(df, plotting_config, outdir) | ||
| _plot_cost_function(df, plotting_config, outdir) |
There was a problem hiding this comment.
weird no end of line thing here again like what happens sometimes
| plotting_config = {} | ||
| plotting_config['tm'] = tm | ||
| current_file = fits2_data[-1].split('/')[-1] | ||
| plotting_config['experiment'] = current_file.split('.')[0] |
There was a problem hiding this comment.
what does this return? Ideally experiment would be a YAML defined thing I think.
| @@ -99,13 +99,15 @@ def plotting(config, data_dict, outdir, data_type, ob_type): | |||
| plot_dict[plot_type](fits_df, plotting_config, outdir) | |||
|
|
|||
|
|
|||
| def create_minimization_plots(data_dict, outdir): | |||
| def create_minimization_plots(data_dict, experiment_type, outdir): | |||
There was a problem hiding this comment.
I'm nitpicking but can you change this to experiment_name? Once we have something running, someone might run an experiment to test something new like my_new_radiosonde_test or use_more_data and not just one of 'LAMDA, LAMDAX, etc.'. Then I will approve.
Addresses 1.) in #84. Creates two minimization plots for a single cycle: Jo and gradnorm
Jo:
Gradnorm: