Skip to content

Commit

Permalink
update RDASApp submodules to match mpasjedi-v3.0.1 (#194)
Browse files Browse the repository at this point in the history
List of submodule changes.  issue #193 
```
ioda             c7b8760f -> d49ed17e
ufo              92ccfb2a -> 94d50d64
oops             35820130 -> d77217323
vader            e3457cba -> 6d56a1eb5
mpas             3ecd59e2 -> 41e9a3fb8   #  repo URL also changed
mpas-jedi        a1c60997 -> b9d596d7c
#fv3-jedi         d3c800b8 -> c99519638
#fv3-jedi-lm      a6e97d76 -> 30ef7a390
```

---------

Co-authored-by: guoqing.ge <[email protected]>
  • Loading branch information
Junjun-NOAA and guoqing-noaa authored Oct 22, 2024
1 parent dffa109 commit 6967dd5
Show file tree
Hide file tree
Showing 44 changed files with 2,314 additions and 2,338 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
ignore = all
[submodule "sorc/mpas"]
path = sorc/mpas
url = https://github.com/jcsda-internal/MPAS-Model
url = https://github.com/MPAS-Dev/MPAS-Model
branch = release-stable
ignore = all
[submodule "sorc/mpas-jedi"]
Expand Down
1 change: 1 addition & 0 deletions bundle/mpas-jedi-data/testinput_tier_1/obs
1 change: 0 additions & 1 deletion fix/crtm

This file was deleted.

1 change: 1 addition & 0 deletions fix/crtm/2.3.0
1 change: 1 addition & 0 deletions fix/crtm/2.4.0
1 change: 1 addition & 0 deletions fix/crtm/2.4.1_skylab_4.0
1 change: 1 addition & 0 deletions fix/crtm/fix_REL-3.1.1.2
2 changes: 1 addition & 1 deletion fix/expr_data/mpas_2024052700/bkg
2 changes: 1 addition & 1 deletion fix/expr_data/mpas_2024052700/ens
1 change: 1 addition & 0 deletions fix/expr_data/mpas_2024052700/invariant.nc
2 changes: 1 addition & 1 deletion fix/expr_data/mpas_2024052700/obs
2 changes: 1 addition & 1 deletion fix/jcsda/fv3-jedi-data
2 changes: 1 addition & 1 deletion fix/jcsda/ioda-data
2 changes: 1 addition & 1 deletion fix/physics/VEGPARM.TBL
6 changes: 3 additions & 3 deletions rrfs-test/scripts/link_mpasjedi_expr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ cp ${RDASApp}/rrfs-test/ush/mpasjedi_spread.py .

mkdir -p data
cd data
mkdir -p bumploc bkg obs obs_ctest ens
mkdir -p bumploc obs obs_ctest ens
ln -snf ${RDASApp}/fix/bumploc/${BUMPLOC} bumploc/${BUMPLOC}
ln -snf ${RDASApp}/fix/expr_data/${exprname}/bkg/restart.2024-05-27_00.00.00.nc .
ln -snf ${RDASApp}/fix/expr_data/${exprname}/bkg/restart.2024-05-27_00.00.00.nc static.nc
ln -snf ${RDASApp}/fix/expr_data/${exprname}/bkg/mpasout.2024-05-27_00.00.00.nc .
ln -snf ${RDASApp}/fix/expr_data/${exprname}/invariant.nc invariant.nc
ln -snf ${RDASApp}/fix/expr_data/${exprname}/obs/* obs/
ln -snf ${RDASApp}/fix/expr_data/${exprname}/obs_ctest/* obs_ctest/
ln -snf ${RDASApp}/fix/expr_data/${exprname}/ens/* ens/
Expand Down
4 changes: 2 additions & 2 deletions rrfs-test/scripts/setup_experiment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ elif [[ $DYCORE == "MPAS" ]]; then
mkdir -p data; cd data
mkdir -p bumploc bkg obs ens
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/bumploc/* bumploc/.
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/bkg/restart.2024-05-27_00.00.00.nc .
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/bkg/restart.2024-05-27_00.00.00.nc static.nc
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/bkg/mpasout.2024-05-27_00.00.00.nc .
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/invariant.nc invariant.nc
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/obs/* obs/
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/ens/* ens/
cp -p $YOUR_PATH_TO_RDASAPP/rrfs-test/scripts/templates/run_bump_template.sh run_bump.sh
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput/rrfs_mpasjedi_2024052700_Ens3Dvar.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ cost function:
analysis variables: *incvars
background:
state variables: [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal,theta,rho,u,qv,pressure,landmask,xice,snowc,skintemp,ivgtyp,isltyp,snowh,vegfra,u10,v10,lai,smois,tslb,pressure_p,qc,qi,qg,qr,qs,cldfrac]
filename: data/restart.2024-05-27_00.00.00.nc
filename: data/mpasout.2024-05-27_00.00.00.nc
date: *analysisDate
background error:
covariance model: ensemble
Expand All @@ -66,10 +66,10 @@ cost function:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
2 changes: 1 addition & 1 deletion rrfs-test/testinput/rrfs_mpasjedi_2024052700_bumploc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ geometry:
bump vunit: "modellevel" # modellevel, height
background:
state variables: &vars [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal]
filename: "./data/restart.2024-05-27_00.00.00.nc"
filename: "./data/mpasout.2024-05-27_00.00.00.nc"
date: *validDate

background error:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput/streams.atmosphere
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<streams>
<immutable_stream name="static"
<immutable_stream name="invariant"
type="input"
precision="single"
filename_template="data/static.nc"
filename_template="data/invariant.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

<immutable_stream name="input"
type="input"
precision="single"
filename_template="data/restart.2024-05-27_00.00.00.nc"
filename_template="data/mpasout.2024-05-27_00.00.00.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

Expand Down
66 changes: 20 additions & 46 deletions rrfs-test/testinput_expr/rrfs_mpasjedi_2024052700_Ens3Dvar.yaml
Original file line number Diff line number Diff line change
@@ -1,41 +1,3 @@

# application-agnostic anchors that specify observation errors
# applicable to Variational, HofX3D

# reusable latitude bands for all observation types
_conventional obs localizations: &heightAndHorizObsLoc
_blank: null

_nonconventional obs localizations: &horizObsLoc
_blank: null

_obs space: &ObsSpace
obs perturbations seed: 1
io pool:
max pool size: 10
distribution:
name: RoundRobin

_obs error diagonal: &ObsErrorDiagonal
covariance model: diagonal
# Note: the same 'obs perturbations seed' must be used for all members for the 'zero-mean perturbations' option to work
zero-mean perturbations: true
member: 1
number of members: 1

_get values: &GetValues
nnearest: 3

_multi iteration filter: &multiIterationFilter
apply at iterations: 0,1,2,3,4,5
# ObsAnchors and ObsErrorAnchors are automatically prepended above this line
_iteration: &iterationConfig
geometry:
nml_file: ./namelist.atmosphere
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
gradient norm reduction: 1e-3
_member: &memberConfig
date: &analysisDate '2024-05-27T00:00:00Z'
state variables: &incvars [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal]
Expand All @@ -48,11 +10,23 @@ variational:
minimizer:
algorithm: DRPCG
iterations:
- <<: *iterationConfig
- geometry:
nml_file: ./namelist.atmosphere
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
gradient norm reduction: 1e-3
diagnostics:
departures: ombg
ninner: 50
- <<: *iterationConfig
- geometry:
nml_file: ./namelist.atmosphere
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
gradient norm reduction: 1e-3
diagnostics:
departures: ombg
ninner: 50
final:
diagnostics:
Expand All @@ -68,11 +42,11 @@ cost function:
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
analysis variables: *incvars
analysis variables: *incvars
background:
state variables: [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal,theta,rho,u,qv,pressure,landmask,xice,snowc,skintemp,ivgtyp,isltyp,snowh,vegfra,u10,v10,lai,smois,tslb,pressure_p,qc,qi,qg,qr,qs,cldfrac]
filename: data/restart.2024-05-27_00.00.00.nc
date: *analysisDate
filename: data/mpasout.2024-05-27_00.00.00.nc
date: *analysisDate
background error:
covariance model: ensemble
localization:
Expand All @@ -92,10 +66,10 @@ cost function:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30
observations:
observers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ geometry:
bump vunit: "modellevel" # modellevel, height
background:
state variables: &vars [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal]
filename: "./data/restart.2024-05-27_00.00.00.nc"
filename: "./data/mpasout.2024-05-27_00.00.00.nc"
date: *validDate

background error:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput_expr/rrfs_mpasjedi_2024052700_getkf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput_expr/rrfs_mpasjedi_2024052700_letkf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput_expr/streams.atmosphere
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<streams>
<immutable_stream name="static"
<immutable_stream name="invariant"
type="input"
precision="single"
filename_template="data/static.nc"
filename_template="data/invariant.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

<immutable_stream name="input"
type="input"
precision="single"
filename_template="data/restart.2024-05-27_00.00.00.nc"
filename_template="data/mpasout.2024-05-27_00.00.00.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

Expand Down
Loading

0 comments on commit 6967dd5

Please sign in to comment.