Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to get github actions working (no more error for failed unit test) #198

Merged

Conversation

SamuelDegelia-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA commented Oct 15, 2024

Quick fix for #195 via @CoryMartin-NOAA. This should stop the error for a failed unit test when submitting a PR or adding a new commit.

@guoqing-noaa
Copy link
Collaborator

@SamuelDegelia-NOAA Thanks for the quick fix.

This is a hotfix, so I will merge it right now.

@guoqing-noaa guoqing-noaa merged commit 7eb855b into NOAA-EMC:develop Oct 15, 2024
1 check passed
@SamuelDegelia-NOAA SamuelDegelia-NOAA deleted the hotfix/github_actions branch October 15, 2024 19:18
@@ -3,7 +3,7 @@ on: [push, pull_request]

jobs:
ctests:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuelDegelia-NOAA Could you explain why the changes of the virtual machine type would resolve this issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TingLei-NOAA I am not sure why it fixes it. The error was related to pip, so I am guessing that there was an update to the latest default ubuntu version that broke pip. @CoryMartin-NOAA might have more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuelDegelia-NOAA 's hunch is the same as mine. I'd rather just deal with this later when that version of the virtual machine is no longer available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuelDegelia-NOAA @CoryMartin-NOAA Thanks for this explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants