Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for offline domain check longitude range #222

Merged

Conversation

SamuelDegelia-NOAA
Copy link
Contributor

A quick fix for the problem described here by @HuiLiu-NOAA. The conventional version of the offline domain check was not configured to work with obs whose longitudes range from (-180, 180). This line exists in offline_domain_check_satrad.py but needs to be added to offline_domain_check.py.

Copy link
Collaborator

@delippi delippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is an easy one. Thanks for making the PR for this.

Copy link
Collaborator

@HuiLiu-NOAA HuiLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this offline tool would remain very useful even after the online one is fully functional.

@delippi
Copy link
Collaborator

delippi commented Nov 7, 2024

Thanks! I think this offline tool would remain very useful even after the online one is fully functional.

I agree with this statement. Just the other day, it came up about matching ob counts when we do FV3 vs MPAS comparisons since grids wont match 100%. We can use the smaller of the two grids using the offline domain check to get the exact number of obs when doing our comparisons.

@hu5970 hu5970 merged commit 2fcfe76 into NOAA-EMC:develop Nov 7, 2024
1 check passed
@SamuelDegelia-NOAA SamuelDegelia-NOAA deleted the hotfix/domaincheck_longitude branch November 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants