Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langmuir turbulence parameterization improvements #1034

Merged

Commits on Jun 26, 2023

  1. Clean up diagnostic variables in WW3 for Langmuir turbulence paramete…

    …rization
    
    In addition to the changes by @qingli411 as summarized below, I have added mod_def namelist parameters to control the Langmuir parameterization and eliminated the CESMCOUPLED and SDTAIL ifdefs by replacing them with if statements (with flags from the newly added namelist) wherever applicable.
    
     # Pull Request Summary
    This PR cleans up the calculation of Stokes drift and other diagnostics variables in WW3 for Langmuir turbulence parameterization in CESM.
    
    * Clean up the calculations of the surface Stokes drift (`USSX` and `USSY`) and surface layer averaged Stokes drift (`USSHX` and `USSHY`). The calculation of surface layer averaged Stokes drift and the tail contributions to both versions of Stokes drift are activated when `W3_CESMCOUPLED` is defined.
    * Change the input field of mixed layer depth `HML` to a more general surface layer depth `HSL`. This depth is used to calculate the surface layer averaged Stokes drift. When used in CESM, the surface layer depth is defined as 1/5 of the mixed layer depth. Now this 1/5 factor is applied to the mixed layer depth when importing the fields in the cap.
    * Clean up the diagnostic variables for Langmuir turbulence parameterization. Some variables are intermediate quantities and are not used in the parameterization. These variables are now deleted. The key variable diagnosed in WW3 is the surface layer averaged Stokes drift (`USSHX` and `USSHY`). The Langmuir enhancement factor (`LAMULT`) and the surface layer averaged Langmuir number (`LASL`) are now calculated when they are exported in the cap. `LASL` is needed for the Langmuir induced entrainment parameterization in CVMix but was not there in the cap code. So it is now added following the way `LAMULT` is defined.
    * This PR only changes the diagnostic variables in WW3 and shouldn't change the answers of WW3. Ideally, this PR shouldn't change the diagnostic variables to be used in CESM (`LAMULT`, `LASL`) as well. But given that the calculation of these variables are moved to the cap, and the way division by zero and physically invalid values (both should be rare) are handled, small changes to these variables are expected.
    
    Co-authored-by: qingli411 <[email protected]>
    alperaltuntas and qingli411 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8101d60 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    1f1c05f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7af1188 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #9 from ESCOMP/dev/unified_new_merge_pr4

    (Latest PR) Clean up diagnostic variables in WW3 for Langmuir turbulence parameterization
    alperaltuntas authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a4fbf16 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Revert "CMakeLists changes for CESM"

    This reverts commit 7af1188.
    alperaltuntas committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e980324 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    e8f1d7e View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    a8ebf89 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    a70244d View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    695ef06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8237fd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9bc25b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0903907 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Merge pull request #11 from MatthewMasarik-NOAA/regtest/sync-dev/unified

    Langmuir turbulence parameterization - PR polishing
    alperaltuntas authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3d39cf0 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Configuration menu
    Copy the full SHA
    7f29db6 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Configuration menu
    Copy the full SHA
    f79e156 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    5b1a73a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e7d8b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd89cfe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    63ac370 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0a9e547 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    670d1f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Configuration menu
    Copy the full SHA
    3f55d26 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bb8e11 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    86873ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    500f6a4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58fef56 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    743044c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a129698 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ac7ab56 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    94801a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25750e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1be8e33 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e789a21 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c1f4b84 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f1d5b93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b1ddc7f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d7ced8b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    00ea016 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e3e950b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ecbce55 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    c9cfedd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b865de1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    7b013da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a5ea67 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    84ec561 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8250be0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    258a772 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    921f7a0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4c0ee1c View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Merge pull request #15 from MatthewMasarik-NOAA/sync-dev-unified

    Langmuir PR: regtest and documentation polishing
    alperaltuntas authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    90cd7c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Configuration menu
    Copy the full SHA
    1effbd7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc6f815 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    53682b5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4db3dd8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c200ab0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5197ac0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    308d7a7 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #16 from MatthewMasarik-NOAA/comments/sync-dev/uni…

    …fied
    
    Langmuir updates:  PR to address comments made on NOAA-EMC/WW3 NOAA-EMC#1034
    alperaltuntas authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    fe15c2a View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    75dc7da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef8e038 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    586450e View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    ea361a5 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/mods/dev/ufs-weather-model' into…

    … fix2/sync-dev/unified
    
    * origin/mods/dev/ufs-weather-model:
      matrix_cmake_ncep: update modules for spack-stack
      prevent division by 0 in appendtail and add timers to meshcap  (NOAA-EMC#1163)
    MatthewMasarik-NOAA committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0698bc1 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    3caad4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e7b1ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a10573c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3072952 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6944915 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Merge pull request #19 from MatthewMasarik-NOAA/fix2-no-mods/sync-dev…

    …/unified
    
    Fix for ww3_tp2.22 plus updates from dev/ufs-weather-model
    alperaltuntas authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8c7ec7b View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    749feab View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge pull request #20 from MatthewMasarik-NOAA/format/sync-dev/unified

    w3iogomd.F90: fix IF-stmt indention
    alperaltuntas authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    32611c5 View commit details
    Browse the repository at this point in the history