Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build 'remarks' #1201

Merged

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Mar 8, 2024

Pull Request Summary

Resolves compiler 'remark's from building the develop branch.

Description

  • Provide a detailed description of what this PR does.
    • Fixes the width descriptors in WW3 source which cause the compiler to output remarks. This involved enforcing the suggested width, W>=D+7, by choosing the minimal change, W=D+7. This PR is for the develop branch. After acceptance it will be PR'd to the dev/ufs-weather-model branch to resolve the WW3 portion of Compiler warnings may not be suppressed ufs-community/ufs-weather-model#1984. The remarks fixed for develop are shown below. Note, there is one additional remark to be fixed in the dev/ufs-weather-model branch.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/ww3-verify-current/model/src/w3arrymd.F90(2255): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/ww3-verify-current/model/src/w3arrymd.F90(2256): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/ww3-verify-current/model/src/w3arrymd.F90(2253): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/ww3-verify-current/model/src/w3tidemd.F90(826): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/ww3-verify-current/model/src/w3tidemd.F90(830): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
/scratch1/NCEPDEV/climate/Matthew.Masarik/projs/UFS/support/ww3-verify-current/model/src/ww3_outf.F90(2436): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
  • Is a change of answers expected from this PR?
    • The ww3_grid.out log files will differ due to spacing from the updated width descriptors.

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added:
    • bug
  • Are answer changes expected from this PR?
    • No, but beware when running matrix.comp that many log files will have differences due to the adjusted width of output fields.

Issue(s) addressed

  • Please list any issues associated with this PR, including those the PR will fix/close.

Commit Message

Fix compiler build 'remark's

Check list

Testing

  • How were these changes tested?
    • Comparison of regtest matrix runs.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • The changes are fixes -- no new test needed.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • Yes. hera / intel.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    • No answer changes, though expect log file differences.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Verification of fix

@MatthewMasarik-NOAA MatthewMasarik-NOAA marked this pull request as ready for review March 11, 2024 18:22
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses the remarks seen when building with a particular switch file. The overall number of remarks are now reduced.

There are changes in outputs but not actual answer changes with this PR. There are too many diffs to list but the logs are attached:

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit f66b6d4 into NOAA-EMC:develop Mar 13, 2024
40 checks passed
MatthewMasarik-NOAA added a commit to MatthewMasarik-NOAA/WW3 that referenced this pull request Mar 26, 2024
sbanihash pushed a commit to sbanihash/WW3 that referenced this pull request Mar 26, 2024
MatthewMasarik-NOAA added a commit that referenced this pull request Mar 27, 2024
Co-authored-by: saeideh banihashemi <[email protected]>
Co-authored-by: Matthew Masarik <[email protected]>
@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the fix/build-remarks branch June 24, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve compiler build 'remarks'
2 participants