-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring additional changes to support UFS Coastal App #1255
Bring additional changes to support UFS Coastal App #1255
Conversation
@JessicaMeixner-NOAA I created a draft PR that includes minor changes for UFS Coastal App. I was using |
@JessicaMeixner-NOAA I'll also run couple of tests that is found in ufs-weather-model to be sure those changes are not affecting any existing configurations. |
@uturuncoglu thanks for making this PR!!! I look forward to looking into this PR in detail. It will likely be early next week before I provide additional comments so I can take the time to look with proper attention. Again - thanks for making this PR! |
@JessicaMeixner-NOAA Sure. No worries. I am still on vacation but will return next week. |
@JessicaMeixner-NOAA Sorry for being late about changes that we discussed in our last call. As we decided, I'll remove the modifications related with build, cap changes to allow standalone WW3 run and also the switch file. So, the only remaining part would be the fix for the NUOPC cap that allows coupling through the radiation stress component. I am plaining to create another branch for it and new PR in here. Once, it is ready, I'll close this draft PR and continue to the conversation in new PR. Let me know what you think? |
@JessicaMeixner-NOAA I have just checked the |
Thanks for the update @uturuncoglu that sounds great! |
@JessicaMeixner-NOAA Closing this since we have new PR - #1272 |
Pull Request Summary
This PR aims to bring minor modifications to support UFS Coastal App specific model configurations.
Description
Following is the list of the changes,
BUILD_TOOLS
option is included to build system to build tools. This isOFF
by default and does not change the current behavior.SCRIP
andSCRIPNC
tomodel/bin/switch_meshcap_pdlib
switch file since the mesh file was not generated by default. If this is not right way to do it maybe we could create another copy of this file and point that one under UFS Coastal App.model/src/wav_comp_nuopc.F90
is modified to support standalone runs under ufs-weather-model. Oncestandalone
option under wave section ofufs.configure
is set totrue
, then the model reads its own forcing rather than getting data from coupling. So, this will allow standalone wave configurations without any other component.Sw_wavsuu
,Sw_wavsuv
andSw_wavsvv
) in a correct way. This is tested with SCHSIM ocean model coupling with DATM+SCHSIM+WW3 configuration.Issue(s) addressed
Commit Message
Check list
Testing
How were these changes tested?
The changes are tested under UFS Coastal App.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the matrix regression tests been run (if yes, please note HPC and compiler)?
Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):