MYNN-EDMF Updates #630
Closed
MYNN-EDMF Updates #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2023
haiqinli
added a commit
to haiqinli/fv3atm
that referenced
this pull request
Mar 13, 2023
|
@joeolson42 For UFS regression testing, please edit the .gitmodules file in the FV3 directory to have the following: |
|
done
…On Mon, Mar 13, 2023 at 7:10 PM Grant Firl ***@***.***> wrote:
@joeolson42 <https://github.com/joeolson42> For UFS regression testing,
please edit the .gitmodules file in the FV3 directory to have the following:
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/joeolson42/ccpp-physics
branch = mynn_01March
—
Reply to this email directly, view it on GitHub
<#630 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLRR3WFK3O2NJCR2ETIPLDW37AQXANCNFSM6AAAAAAVMKYRKY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Joseph Olson
Model Physics Branch Chief
Environmental Prediction Advancement Division
NOAA-Global Systems Laboratory
Boulder, Colorado
|
jkbk2004
pushed a commit
that referenced
this pull request
Mar 27, 2023
* MYNN update * "merge RRFS-SD from the GSL repo to the Community repo" * "include MYNN-EDMF updates from PR #630" Co-authored-by: joeolson42 <[email protected]> Co-authored-by: Haiqin.Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit includes the following:
This PR is connected with a ccpp-physics PR (#43) to the ufs/dev branch
Testing
These changes have been well tested in SCM. RRFS and some global case studies, almost entirely with the intel compiler on Hera and Jet.
Are the changes covered by regression tests? The TKE budget changes are not yet covered by a regression test, since they are only for use in research and require more 3D output fields. Other (physics) changes are covered by regression tests.
Have the ufs-weather-model regression test been run? Running them on Hera now.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs