Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GDASApp to CRTM 2.4 #1773

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Move GDASApp to CRTM 2.4 #1773

merged 5 commits into from
Aug 8, 2023

Conversation

CoryMartin-NOAA
Copy link
Contributor

Description

This PR moves the GDASApp to CRTM 2.4. It also removes the need for the global-workflow team to maintain CRTM coefficients in their fix space, instead we should be linking/copying them from wherever the CRTM coefficients are stored (like the way GSI does it). For now, that is an 'unofficial' location, but will eventually be the 'official' one.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Clone and Build tests on Hera
  • Cycled test on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Aug 4, 2023
@CoryMartin-NOAA
Copy link
Contributor Author

This hasn't been tested yet. I will do so and give the thumbs up once everything works as intended.

aerorahul
aerorahul approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with this.
A couple of requests.

parm/gdas/aero_crtm_coeff.yaml Outdated Show resolved Hide resolved
parm/gdas/aero_crtm_coeff.yaml Outdated Show resolved Hide resolved
@CoryMartin-NOAA
Copy link
Contributor Author

Ok this is ready, it builds and GDASApp tests that use the workflow are working as intended.

@CoryMartin-NOAA
Copy link
Contributor Author

I will update the GDASApp hash once NOAA-EMC/GDASApp#550 is merged

@jiaruidong2017
Copy link
Contributor

@CoryMartin-NOAA Would you please merge develop to feature/stable-nightly in GDASApp and update the commit hash to include recent updates from https://github.com/JCSDA-internal/fv3-jedi/pull/980. Thanks.

@jiaruidong2017
Copy link
Contributor

@CoryMartin-NOAA I just checked the current commit hash 7966501 already included the above changes from https://github.com/JCSDA-internal/fv3-jedi/pull/980. Please ignore my above request.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Aug 8, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Aug 8, 2023
@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Tue Aug  8 02:12:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 02:14:18 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 02:41:56 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:41:59 CDT 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:03 CDT 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:06 CDT 2023 for experiment C96_atm3DVar_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:10 CDT 2023 for experiment C96C48_hybatmDA_629894a8

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Aug 8, 2023
@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Tue Aug  8 07:12:50 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 07:17:59 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 07:43:44 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:52 UTC 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:58 UTC 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:07 UTC 2023 for experiment C96C48_hybatmDA_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:14 UTC 2023 for experiment C96_atm3DVar_629894a8

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Tue Aug  8 02:12:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 02:14:18 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 02:41:56 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:41:59 CDT 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:03 CDT 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:06 CDT 2023 for experiment C96_atm3DVar_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:10 CDT 2023 for experiment C96C48_hybatmDA_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 03:16:11 CDT 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Tue Aug  8 07:12:50 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 07:17:59 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 07:43:44 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:52 UTC 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:58 UTC 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:07 UTC 2023 for experiment C96C48_hybatmDA_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:14 UTC 2023 for experiment C96_atm3DVar_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 08:27:17 UTC 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Tue Aug  8 02:12:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 02:14:18 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 02:41:56 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:41:59 CDT 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:03 CDT 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:06 CDT 2023 for experiment C96_atm3DVar_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:10 CDT 2023 for experiment C96C48_hybatmDA_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 03:16:11 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 03:46:07 CDT 2023
with 48 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Tue Aug  8 07:12:50 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 07:17:59 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 07:43:44 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:52 UTC 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:58 UTC 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:07 UTC 2023 for experiment C96C48_hybatmDA_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:14 UTC 2023 for experiment C96_atm3DVar_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 08:27:17 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 08:57:09 UTC 2023
with 48 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Tue Aug  8 02:12:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 02:14:18 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 02:41:56 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:41:59 CDT 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:03 CDT 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:06 CDT 2023 for experiment C96_atm3DVar_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:10 CDT 2023 for experiment C96C48_hybatmDA_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 03:16:11 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 03:46:07 CDT 2023
with 48 successfully completed jobs
Experiment C96_atm3DVar_629894a8 completed: *SUCCESS*
Experiment C96_atm3DVar_629894a8 Completed at Tue Aug  8 05:26:07 CDT 2023
with 89 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Tue Aug  8 07:12:50 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 07:17:59 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 07:43:44 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:52 UTC 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:58 UTC 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:07 UTC 2023 for experiment C96C48_hybatmDA_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:14 UTC 2023 for experiment C96_atm3DVar_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 08:27:17 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 08:57:09 UTC 2023
with 48 successfully completed jobs
Experiment C96C48_hybatmDA_629894a8 completed: *SUCCESS*
Experiment C96C48_hybatmDA_629894a8 Completed at Tue Aug  8 10:51:19 UTC 2023
with 151 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Tue Aug  8 02:12:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 02:14:18 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 02:41:56 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:41:59 CDT 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:03 CDT 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:06 CDT 2023 for experiment C96_atm3DVar_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:10 CDT 2023 for experiment C96C48_hybatmDA_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 03:16:11 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 03:46:07 CDT 2023
with 48 successfully completed jobs
Experiment C96_atm3DVar_629894a8 completed: *SUCCESS*
Experiment C96_atm3DVar_629894a8 Completed at Tue Aug  8 05:26:07 CDT 2023
with 89 successfully completed jobs
Experiment C96C48_hybatmDA_629894a8 completed: *SUCCESS*
Experiment C96C48_hybatmDA_629894a8 Completed at Tue Aug  8 05:56:08 CDT 2023
with 151 successfully completed jobs

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Aug 8, 2023
@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Tue Aug  8 02:12:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 02:14:18 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 02:41:56 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:41:59 CDT 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:03 CDT 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:06 CDT 2023 for experiment C96_atm3DVar_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 02:42:10 CDT 2023 for experiment C96C48_hybatmDA_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 03:16:11 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 03:46:07 CDT 2023
with 48 successfully completed jobs
Experiment C96_atm3DVar_629894a8 completed: *SUCCESS*
Experiment C96_atm3DVar_629894a8 Completed at Tue Aug  8 05:26:07 CDT 2023
with 89 successfully completed jobs
Experiment C96C48_hybatmDA_629894a8 completed: *SUCCESS*
Experiment C96C48_hybatmDA_629894a8 Completed at Tue Aug  8 05:56:08 CDT 2023
with 151 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Tue Aug  8 07:12:50 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 07:17:59 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 07:43:44 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:52 UTC 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:58 UTC 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:07 UTC 2023 for experiment C96C48_hybatmDA_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:14 UTC 2023 for experiment C96_atm3DVar_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 08:27:17 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 08:57:09 UTC 2023
with 48 successfully completed jobs
Experiment C96C48_hybatmDA_629894a8 completed: *SUCCESS*
Experiment C96C48_hybatmDA_629894a8 Completed at Tue Aug  8 10:51:19 UTC 2023
with 151 successfully completed jobs
Experiment C96_atm3DVar_629894a8 completed: *SUCCESS*
Experiment C96_atm3DVar_629894a8 Completed at Tue Aug  8 11:21:12 UTC 2023
with 89 successfully completed jobs

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Aug 8, 2023
@emcbot
Copy link

emcbot commented Aug 8, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Tue Aug  8 07:12:50 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Tue Aug  8 07:17:59 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Tue Aug  8 07:43:44 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:52 UTC 2023 for experiment C48_ATM_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:43:58 UTC 2023 for experiment C48_S2S_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:07 UTC 2023 for experiment C96C48_hybatmDA_629894a8
Created experiment:            *SUCCESS*
Case setup: Completed at Tue Aug  8 07:44:14 UTC 2023 for experiment C96_atm3DVar_629894a8
Experiment C48_S2S_629894a8 completed: *SUCCESS*
Experiment C48_S2S_629894a8 Completed at Tue Aug  8 08:27:17 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_629894a8 completed: *SUCCESS*
Experiment C48_ATM_629894a8 Completed at Tue Aug  8 08:57:09 UTC 2023
with 48 successfully completed jobs
Experiment C96C48_hybatmDA_629894a8 completed: *SUCCESS*
Experiment C96C48_hybatmDA_629894a8 Completed at Tue Aug  8 10:51:19 UTC 2023
with 151 successfully completed jobs
Experiment C96_atm3DVar_629894a8 completed: *SUCCESS*
Experiment C96_atm3DVar_629894a8 Completed at Tue Aug  8 11:21:12 UTC 2023
with 89 successfully completed jobs

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ca7d242 into NOAA-EMC:develop Aug 8, 2023
4 checks passed
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Aug 8, 2023
Merged
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/crtm branch June 14, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@ADCollard ADCollard Awaiting requested review from ADCollard

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CoryMartin-NOAA @jiaruidong2017 @emcbot @aerorahul @WalterKolczynski-NOAA