-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gefs test #1774
Add a gefs test #1774
Conversation
@aerorahul I see that this is for S2SA, is there a reason that waves are excluded? |
No particular reason. |
addressed comments. requesting re-review
What is the IC date, number of ensembles and resolution - that's something that can be easily fixed. |
See the ci/cases/C48_S2SA_gefs.yaml file added in this PR for the initial condition date, ensemble size and resolution. |
Yup, the reason I didn't run waves in my GEFS instructions (which Rahul presumably used to make the test) was because we don't have wave ICs (at least not in the official place with the others). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditionally approved pending CI tests
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Description
This PR:
setup_expt.py
to compartmentalize gfs and gefs setup options. gefs has a single modeforecast-only
and is necessary forcreate_experiment.py
to work as designed. To eliminate it would need major work.Type of change
How Has This Been Tested?
This should be a companion PR to #1772
Checklist