Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASH wrapper to create_experiment.py #1788

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

Description

Adding BASH wrapper to create_experiment.py so users can use it directly (it previously needed several environments settings found in ../platforms/${MACHINE}.sh). Also removed redundant argument the python script.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This was tested by creating experiments with only the needed arguments and checked them with $HOMEgfs/workflow/test_configuration.py

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

TerrenceMcGuinness-NOAA and others added 30 commits June 7, 2023 09:40
no op change for test
no op change for test
removed second label orion-ready
added pull request TARGET
aerorahul and others added 25 commits July 11, 2023 17:02
github.run_id not github.run.id !!
still need pslot at end of arg to setup_xml
old extra pslot still in EXPDIR path now removed
took out condition on label
two more only one uses per step
…nd line, removed redundent seceond argument to it as well
@github-actions
Copy link

Link to ReadTheDocs sample build for this PR can be found at:
https://global-workflow--1788.org.readthedocs.build/en/1788

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA changed the title BASH wrapper to create_experiment BASH wrapper to create_experiment.py Aug 10, 2023
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA deleted the feature/bash_create_expt branch August 10, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants