Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JGDAS ENKF SELECT OBS job #3092

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Update JGDAS ENKF SELECT OBS job #3092

wants to merge 5 commits into from

Conversation

mingshichen-noaa
Copy link
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jgdas enkf select obs job.

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 12, 2024
View reviewed changes
jobs/JGDAS_ENKF_SELECT_OBS Fixed Show resolved Hide resolved
@mingshichen-noaa mingshichen-noaa self-assigned this Nov 12, 2024
@mingshichen-noaa mingshichen-noaa added the CI/CD Issue related to CI/CD label Nov 12, 2024
aerorahul
aerorahul reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I am no longer familiar w/ the IN and OUT of EnKF related data, so would appreciate a review from @CatherineThomas-NOAA @RussTreadon-NOAA

KateFriedman-NOAA
KateFriedman-NOAA reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please resolve the shellcheck warning in jobs/JGDAS_ENKF_SELECT_OBS and then I can approve.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI/CD Issue related to CI/CD label Nov 13, 2024
aerorahul
aerorahul approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mingshichen-noaa !

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 15, 2024
@emcbot emcbot removed the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 15, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 15, 2024
@emcbot
Copy link

emcbot commented Nov 15, 2024

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmDA_01216a52/logs/2021122100/enkfgdas_eobs.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 15, 2024
@emcbot
Copy link

emcbot commented Nov 15, 2024

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/EXPDIR/C96C48_hybatmDA_01216a52

@emcbot
Copy link

emcbot commented Nov 15, 2024

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_01216a52/logs/2021122018/enkfgdas_eobs.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Nov 15, 2024

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_01216a52

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 15, 2024
@emcbot
Copy link

emcbot commented Nov 15, 2024

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3092


Experiment C96C48_hybatmDA_01216a52 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Nov 15 10:31:28 UTC 2024
Experiment C96C48_hybatmDA_01216a52 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmDA_01216a52/logs/2021122100/enkfgdas_eobs.log
Experiment C96C48_hybatmaerosnowDA_01216a52 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Nov 15 10:37:33 UTC 2024
Experiment C96C48_hybatmaerosnowDA_01216a52 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_01216a52/logs/2021122018/enkfgdas_eobs.log
Experiment C96_S2SWA_gefs_replay_ics_01216a52 Completed 1 Cycles: *SUCCESS* at Fri Nov 15 11:07:58 UTC 2024
Experiment C48_ATM_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 11:20:08 UTC 2024
Experiment C48mx500_3DVarAOWCDA_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 11:20:09 UTC 2024
Experiment C48_S2SWA_gefs_01216a52 Completed 1 Cycles: *SUCCESS* at Fri Nov 15 12:21:30 UTC 2024
Experiment C96_atm3DVar_01216a52 Completed 3 Cycles: *SUCCESS* at Fri Nov 15 12:45:34 UTC 2024
Experiment C48_S2SW_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 13:03:46 UTC 2024
Experiment C96C48_ufs_hybatmDA_01216a52 Completed 3 Cycles: *SUCCESS* at Fri Nov 15 13:22:01 UTC 2024

@aerorahul
Copy link
Contributor

@mingshichen-noaa
The tests failed overnight because of changes made in the j-job impacted the scripts called by the j-job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA left review comments

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA RussTreadon-NOAA is a code owner

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA CatherineThomas-NOAA is a code owner

@DavidGrumm-NOAA DavidGrumm-NOAA Awaiting requested review from DavidGrumm-NOAA

Assignees

@mingshichen-noaa mingshichen-noaa

Labels
CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mingshichen-noaa @emcbot @aerorahul @WalterKolczynski-NOAA @KateFriedman-NOAA @DavidHuber-NOAA @TerrenceMcGuinness-NOAA