Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the marine static-b yaml #30

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

guillaumevernieres
Copy link
Contributor

Adjusting yaml to reflect the switch to using oops::utils::FieldSetHelpers::write/readFieldSet ...
I fail to see the point of this repo, what was wrong with keeping the yamls in the gdasapp?

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is correct. Approve.

@guillaumevernieres guillaumevernieres merged commit 2b46aa1 into develop Oct 3, 2024
1 check failed
@guillaumevernieres guillaumevernieres deleted the feature/update_hashes branch October 3, 2024 00:48
guillaumevernieres added a commit to NOAA-EMC/GDASApp that referenced this pull request Oct 3, 2024
I have yet to update the # for `jcb-gdas`. This will be done when
[/NOAA-EMC/jcb-gdas/pull/30](NOAA-EMC/jcb-gdas#30)
is merged.

This branch requires changes in the `global-worflow` as well, see here:
[https://github.com/guillaumevernieres/global-workflow/tree/feature/update_hashes](https://github.com/guillaumevernieres/global-workflow/tree/feature/update_hashes)
. We'll need to update the # and coordinate the merge ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants