Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates needed for parm/wmo data cards #663

Merged

Conversation

BenjaminBlake-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • In this PR, several issues were resolved with the data cards located in parm/wmo that are used for generating the WMO header products. Those are outlined here:
  • The f00 data card contained the max hourly and accumulation fields, which are not present in the f00 grib2 files. These fields have been removed. The resulting WMO grib2 file contains 329 bulletins and 329 records.
  • The total column fields have been removed from RRFS, so TCOLG had to be removed from all of the data cards.
  • Data cards were missing for forecast hours 30, 42, and 54. Data cards were created for these forecast hours, and the resulting WMO grib2 files contained 336 bulletins and 336 records.
  • The file permissions for these data cards were updated via chmod +x.
  • The FAA/IFI data cards were unmodified. Should they be removed from parm/wmo since they will not be included in RRFSv1?
  • The WMO file generation process still needs to be added to the workflow, but that can be done later.

TESTS CONDUCTED:

WMO header grib2 files were generated for the following forecast hours: f00, f01, f30, f42, f54. All bulletins in the data cards were successfully written out to the resulting grib2 files.

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@AndrewBenjamin-NOAA provided me with an example script for generating WMO header grib2 files.

@MatthewPyle-NOAA
Copy link
Contributor

Another question is whether we'll eventually need parm files out to 84 h. But lots of questions about how much we'll be able to send, and it certainly won't be hourly to 84 h.

@BenjaminBlake-NOAA
Copy link
Contributor Author

@MatthewPyle-NOAA That is true, good point. Once those decisions are finalized I can make adjustments to these parm files as needed.

@MatthewPyle-NOAA
Copy link
Contributor

Just a note that I did start some work on AWIPS processing under https://github.com/MatthewPyle-NOAA/rrfs-workflow/tree/feature/awips Haven't returned to it for a while.

Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and harmless to me...thanks for the update.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit efaab2a into NOAA-EMC:main Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants