Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix to assign all missing QualityMarker values to 15 #668

Merged

Conversation

guoqing-noaa
Copy link
Contributor

This PR is to address the real-time MPAS model crash issue due to unreasonably large increments.
It is caused by observations with missing QualityMarker values, which can not be handled by our current rrfs-workflow MPASJEDI settings.

We will try to make a permanent solution, but it will take a while.

For now, we will put all missing QualityMarker values to 15 so they can be filtered out by specific obs filters.

The added Python script is based on offline_add_var_to_ioda.py developed by Donnie.

Thanks @chunhuazhou, @spanNOAA and @hu5970 for quickly identifying the cause.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit c31d81e into NOAA-EMC:rrfs-mpas-jedi Mar 5, 2025
@delippi
Copy link
Contributor

delippi commented Mar 5, 2025

I see now, the missing QMs are causing those unreasonably large increments. Nice job finding the problem.

I also preferred the word "modify" over "tweak" in the name but not such a big deal.

Can someone send me the path to a run which has the missing QualityMarks for the data? I would like to double check the yaml and also try some modifications that I have in mind for a more robust fix. @guoqing-noaa @chunhuazhou @HuiLiu-NOAA

@HuiLiu-NOAA
Copy link

@guoqing-noaa : This can be fixed easily in prepbufr2ioda.yaml by setting the QualityMarker to 15 as default value.

@guoqing-noaa guoqing-noaa deleted the hotfix-qcflag branch March 5, 2025 17:51
@guoqing-noaa
Copy link
Contributor Author

@guoqing-noaa : This can be fixed easily in prepbufr2ioda.yaml by setting the QualityMarker to 15 as default value.

@HuiLiu-NOAA Could you show which line we should change?

@chunhuazhou
Copy link
Collaborator

@delippi You can find the ioda_aircar.nc with missing QC on jet at /lfs6/BMC/wrfruc/Chunhua.Zhou/data/saved_jedivar_cases/MPAS_conus12km/2025022701/jedivar_01.3DVar.newQC/data/obs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants