Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests using FTP #124

Merged
merged 18 commits into from
May 9, 2024
Merged

Conversation

AlysonStahl-NOAA
Copy link
Collaborator

Part of #118

@edwardhartnett
Copy link
Contributor

Failing because:

0s
Run mkdir ~/data
mkdir: cannot create directory ‘/home/runner/data’: File exists
Error: Process completed with exit code 1.

I don't understand what this is failing.

I suggest you first remove the data caching and see if it works downloading everything every time. Then we can circle back around to get the cache working...

@edwardhartnett
Copy link
Contributor

If this is adding a large test file (> 2 GB) from FTP then also add an additional CMake option in the main CMake file:

option(FTP_LARGE_TEST_FILES "Fetch and test with very large files on FTP site." OFF)

Then only get the large test file if this additional option is present.

@AlysonStahl-NOAA
Copy link
Collaborator Author

Failing because:

0s Run mkdir ~/data mkdir: cannot create directory ‘/home/runner/data’: File exists Error: Process completed with exit code 1.

I don't understand what this is failing.

I suggest you first remove the data caching and see if it works downloading everything every time. Then we can circle back around to get the cache working...

I fixed this issue in another pull request which has since been merged. It should be working now.

@AlysonStahl-NOAA
Copy link
Collaborator Author

If this is adding a large test file (> 2 GB) from FTP then also add an additional CMake option in the main CMake file:

option(FTP_LARGE_TEST_FILES "Fetch and test with very large files on FTP site." OFF)

Then only get the large test file if this additional option is present.

This option already exists in the main CMake file and is checked for in the CMake file in the tests folder.

@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review May 6, 2024 20:32
@edwardhartnett edwardhartnett merged commit a5a5bea into NOAA-EMC:develop May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants