Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ip2lib_d by NCEPlib-ip #127

Merged
merged 8 commits into from
May 31, 2024
Merged

replace ip2lib_d by NCEPlib-ip #127

merged 8 commits into from
May 31, 2024

Conversation

webisu
Copy link
Collaborator

@webisu webisu commented May 2, 2024

Replace ip2lib_d by NCEPlib-ip. IP library is now current/maintained. and calls from C to the fortran library now use C/Fortran standards. Previously use the unofficial Unix interface with entry names that varied by compiler.

AlysonStahl-NOAA and others added 3 commits April 19, 2024 11:37
* Added FTP fetch and test

* Update CMakeLists.txt

* Updated CMakeLists.txt for FTP fetch

* Added test for large data file

* Fixed Comment

* Added FTP tests to developer workflow

* Removing large test file from test script for now
* added tests and data files

* data files

* added flags to workflows to use jpeg (required for tests)

* correct flags to use jpeg packing

* reverted changes

* updated test with new data files in complex packing

* trying simple packing to avoid potential jasper errors

* changed test data file names and changed packing types

* swapped checksum comparison for inventory comparison

* fixed typo

* missing file

* another test

* applied fix to developer workflow file
* Added AEC test file

* Fixed typo

* Update run_wgrib2_aec_tests.sh

* Turning openjpeg on in Linux_options workflow to get AEC tests to work

* Update Linux_options.yml

* Updated comment

* Updated aec test and test data

* Updated Linux_options.yml

---------

Co-authored-by: Edward Hartnett <[email protected]>
@edwardhartnett
Copy link
Contributor

This is a pull request to merge from develop into ip_wne_1.

Usually we don't do pull requests, except when merging TO develop.

For other branches, you can merge from the command line, like this:
git checkout develop
git pull
git checkout ip_wne_1
git merge develop
git commit -m "merged develop" -a
git push

After that sequence of commands, ip_wne_1 will have all the changes from develop, and no pull request needed.

If, however, you attempt to do this with the develop branch, you will get an error on the push, telling you that the develop branch is protected, and a pull request is required to commit changes to it.

@webisu you may hit the "Squash and merge" to complete this merge, if that is easier.

AlysonStahl-NOAA and others added 5 commits May 9, 2024 02:43
* added netcdf4 flag to Linux_options.yml

* Update CMakeLists.txt

* Update Config.c

* Added tests for netcdf

* fixed potential source of error in developer workflow

* removed tarball

* restored netcdf tarball

---------

Co-authored-by: Edward Hartnett <[email protected]>
* Added FTP fetch and test

* Update CMakeLists.txt

* Updated CMakeLists.txt for FTP fetch

* Added test for large data file

* Fixed Comment

* Added FTP tests to developer workflow

* Removing large test file from test script for now

* enabled large test files

* typo

* test file was extra large test file

* removing ftp_large_test_files from developer workflow for now

* large test files

* fixing accidentally overwritten changes

* more tests with ftp files

---------

Co-authored-by: Edward Hartnett <[email protected]>
* attempting to remove netcdf tarball

* Update makefile

* removed build workflow

* attempting to remove the rest of the tarballs
* changed test data file name

* adding tests checking use of packing conversion on aec compression

* enabled use of jpeg in workflows for more tests

* test should avoid failure if packing type not enabled

* removing use jasper

* Fixed typo

* added tests using rpn

* typo in file name

* more file name typos

* more tests

* Update run_wgrib2_rpn_tests.sh

* more tests

* more tests

* fixed checksum test

* another test

---------

Co-authored-by: Edward Hartnett <[email protected]>
* added netcdf4 flag to Linux_options.yml

* Update CMakeLists.txt

* Update Config.c

* Added tests for netcdf

* fixed potential source of error in developer workflow

* removed tarball

* restored netcdf tarball

* updated some file names

* temporarily adding flags to developer workflow to view test coverage

* forgot to install libaec in last commit

* more tests

* Update run_wgrib2_netcdf4_tests.sh

* adding more tests

* removed recent test - wasn't working

* fixed comments

* more tests

---------

Co-authored-by: Edward Hartnett <[email protected]>
@edwardhartnett edwardhartnett merged commit f837ef3 into ip_wne_1 May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants