Adding tests which test use of ip external library #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready to merge? |
Nope, not yet. I'm working on adding some of Wesley's unmerged changes that make this compatible with the current version of the ip library. The test I have isn't actually working, I was just testing some things on the CI. |
|
What's the status of this PR? |
From what I understood Wesley was taking over transferring his changes for the newer versions of the ip library. I've been waiting for those changes to complete before I continued with this. |
|
It would be great if this PR could be fixed and merged soon. More testing is more good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #103