Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing some of the tarballs #131

Merged
merged 4 commits into from
May 13, 2024

Conversation

AlysonStahl-NOAA
Copy link
Collaborator

Part of #69
Part of #65

@edwardhartnett
Copy link
Contributor

Go ahead and delete the build.yml file in the workflows. It builds with the old makefile and we don't need to test it.

@AlysonStahl-NOAA
Copy link
Collaborator Author

Go ahead and delete the build.yml file in the workflows. It builds with the old makefile and we don't need to test it.

Ok, will do. It looks like this makefile is the only place where the tarballs are even referenced or used. Are we going to want to remove this old makefile or just update it to look for the libraries?

@edwardhartnett
Copy link
Contributor

Nice!

@edwardhartnett
Copy link
Contributor

Is this ready to merge?

@AlysonStahl-NOAA
Copy link
Collaborator Author

Is this ready to merge?

It should be.

Unless you want me to remove the old makefile?

@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review May 13, 2024 14:41
@edwardhartnett edwardhartnett merged commit 48ab451 into NOAA-EMC:develop May 13, 2024
4 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_tarball branch May 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants