Fixing tests so that they are passing consistently #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I keep rerunning the checks to see if I can break them and I'm not encountering the file comparison problem anymore so that seems to be fixed. Before adding the fix, at least one check was failing every other run or so. I do have one test passing inconsistently, but it seems to be an inconsistent calculation. It's hard to tell what's going on when I can't duplicate the issue anywhere else. Any ideas about how to go about debugging this? |
|
Resolve your conflicts, comment out your one failing test, and get the rest merged. Then circle around and solve the broken test as a separate PR. |
edwardhartnett
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #137