Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing parallel build #180

Merged
merged 14 commits into from
Jul 31, 2024
Merged

Conversation

AlysonStahl-NOAA
Copy link
Collaborator

@AlysonStahl-NOAA AlysonStahl-NOAA commented Jul 12, 2024

Fixes #158

@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review July 30, 2024 17:43
@AlysonStahl-NOAA
Copy link
Collaborator Author

I tested this out on Hera as well and it's working.

@@ -1,5 +1,4 @@


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some comments at the top of all CMakeLists.txt files. Mention that it is a CMake file from the wgrib2 project, and then specify that that CMake file builds. Add an author if you know it (Kyle Gerheiser for all CMake files that were already present in the build. Add your name to the list whenever you make significant changes or additions.

@AlysonStahl-NOAA AlysonStahl-NOAA merged commit e2b4f13 into NOAA-EMC:develop Jul 31, 2024
9 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_parallel branch July 31, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel build fails
2 participants