change ip_4 to ip_d fix test #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, the test worked in the previous version. The interpolated values
were wrong but the ip routine reported an "iret" == 0. The new test
does a check on the interpolated values.
My guess what happened. The ip_4 library was called with real*8 data.
The library did an interpolation assuming real*4 data so there were no
seg faults. Any illegal numbers did cause a fatal crash within iplib
…On Wed, Jul 17, 2024 at 11:08 AM Edward Hartnett ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/data/ref_new_grid_earth_gdas.t12z.pgrb2.1p00.anl.75r.grib2.txt
<#188 (comment)>:
> basic_ang=0 sub_angle=1000000 units=0.000001
- unscaled lat=0 to 180000000 lon=0 to 359000000
-2:8324:grid_template=0:winds(N/S):
Did these tests work before this PR?
—
Reply to this email directly, view it on GitHub
<#188 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIB7ZUVLCOTHDI2RDDPBMLZM2CE7AVCNFSM6AAAAABLAXUKA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBTGIZDEMJZHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
edwardhartnett
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change (2) CMakeLists.txt to use ip_d instead of ip_4, fix run_ipolates_tests.sh