fix for rot lat-lon + 1/n tests #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the same as #221 ? |
|
ip_fix_wne_1 is the fix and 1 test
ip_fix_wne_2 includes ip_fix_wne_1 and additional test
…On Wed, Jul 31, 2024 at 3:13 PM AlysonStahl-NOAA ***@***.***> wrote:
Is this the same as #221 <#221> ?
—
Reply to this email directly, view it on GitHub
<#222 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIB7ZXSU5WWA4R2DNZN2X3ZPEZN7AVCNFSM6AAAAABLZCEMYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRGI2DOMZSG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
They appear to be the exact same changes. Also, are you still doing work on these tests? The data files you added aren't used at all and you added an "exit 1" statement which is causing the tests to fail automatically. |
|
|
||
| echo "*** Testing conversion from earth to grid" | ||
| ../wgrib2/wgrib2 test.grb -new_grid_winds grid \ | ||
| ../wgrib2/wgrib2 new_grid_test.grb -new_grid_winds grid \ |
There was a problem hiding this comment.
Use the name of the test script in the name of any test files produced, like this:
run_ipolates_tests_new_grid_test.grb
Put the test script name first on all of them. Then, when looking at an ls of the test directory, all the test data produced by one test will be easy to see.
edwardhartnett
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test from wmo rot lat-lon to lat-lon grid