USE_NETCDF3/4 -> USE_NETCDF #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
approved these changes
Aug 12, 2024
|
Ed,
Having problems with spack. Tried fixes but nothing is working.
Wesley
…On Mon, Aug 12, 2024 at 2:39 PM Edward Hartnett ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good. Nice cleanup.
—
Reply to this email directly, view it on GitHub
<#228 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIB7ZQO5HJ3A4NBZMXIJSDZRD6MJAVCNFSM6AAAAABMMTX7YGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZTG43TGOJVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Seems to be working now. Still need help? |
|
If it works, then it is ok.
…On Tue, Aug 13, 2024 at 7:36 AM Edward Hartnett ***@***.***> wrote:
Seems to be working now. Still need help?
—
Reply to this email directly, view it on GitHub
<#228 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIB7ZSRFUFNQKKVBA5EQM3ZRHVVFAVCNFSM6AAAAABMMTX7YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBWGAZDQNBQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#227 merge USE_NETCDF3 and USE_NETCDF4 -> USE_NETCDF
eliminate USE_HDF5
default is classic. Use -nc4 to enable netcdf4. Should allow builds with/without hdf5.