Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy fileobj in interpolator_type_eq #1287

Merged
merged 6 commits into from
Aug 31, 2023
Merged

copy fileobj in interpolator_type_eq #1287

merged 6 commits into from
Aug 31, 2023

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Jul 17, 2023

Description
In this PR,

Out%fileobj=In%fileobj

is added to subroutine interpolator_type_eq

Fixes #1286

How Has This Been Tested?
make check passes with Intel on the AMD box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@mlee03
Copy link
Contributor Author

mlee03 commented Aug 3, 2023

@thomas-robinson, referring to our offline conversation, "=" for FmsNetcdfFile_t has been added 😃

@rem1776 rem1776 merged commit 4b9e0e8 into NOAA-GFDL:main Aug 31, 2023
18 checks passed
rem1776 added a commit that referenced this pull request Aug 31, 2023
@rem1776
Revert "feat: add assignment override in fms2_io for interpolator_typ…
2b38193 
…e_eq (#1287)"

This reverts commit 4b9e0e8.
@rem1776 rem1776 mentioned this pull request Aug 31, 2023
Merged
rem1776 added a commit that referenced this pull request Sep 14, 2023
@rem1776
Revert: "feat: add assignment override in fms2_io for interpolator_ty…
61cc3b9 
…pe_eq (#1287)" (#1360)

This reverts commit 4b9e0e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

@bensonr bensonr Awaiting requested review from bensonr bensonr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing copy of fileobj in interpolator_type_eq
2 participants
@mlee03 @rem1776