Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_mpp_nesting unit test #1336

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

laurenchilutti
Copy link
Contributor

@laurenchilutti laurenchilutti commented Aug 16, 2023

Description
When testing with intel ifort and ifx, using the flags -O0 -g -check all we notice that the three test_mpp_nesting tests fail. The failure was due to accessing an unallocated variable. Moving some calls inside of the if(ANY(my_pelist(:)==mpp_pe())) section has resolved this issue.

Fixes #1337

How Has This Been Tested?
tested on Amd development machine with intel oneapi ifort and ifx

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 5326fd9 into NOAA-GFDL:main Aug 16, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intel: test_mpp_nesting test fails
3 participants