Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023.02 Patch #1403

Merged
merged 1 commit into from
Nov 6, 2023
Merged

2023.02 Patch #1403

merged 1 commit into from
Nov 6, 2023

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Nov 2, 2023 •
edited
Loading

Description
This brings in the fix to mpp_gather/mpp_scatter to address the seg faults crashes when using GNU after the 2023.01.01 tag.

This is to address ufs-community/ufs-weather-model#1147 (comment)

As they need this fix and are not ready to move to 2023.03 yet.

Fixes # (issue)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

bensonr
bensonr approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rem1776 rem1776 merged commit 90c98fa into NOAA-GFDL:release/2023.02 Nov 6, 2023
12 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenchilutti laurenchilutti laurenchilutti approved these changes

@rem1776 rem1776 rem1776 approved these changes

@bensonr bensonr bensonr approved these changes

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson thomas-robinson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uramirez8707 @bensonr @rem1776 @laurenchilutti