Make define_blocks warning a note #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
requested review from
bensonr,
rem1776 and
thomas-robinson
as code owners
|
It looks like this is hitting some kind of deadlock in the CI and is hanging during the openmp test for the new diag_manager. It only happens for the builds that have openmp turned off though. https://github.com/NOAA-GFDL/FMS/actions/runs/10774360061/job/29934973086?pr=1588#step:7:6253 You should be able to reproduce it if you configure with |
rem1776
approved these changes
Sep 11, 2024
bensonr
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update so that only the root pe outouts the non uniform block size warning instead of every PE, which will make the stdout very large.
Fixes #1570
How Has This Been Tested?
CI
Checklist:
make distcheckpasses